Fix default path fallack when core.sources:download_cache is not set
#15109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
reviewed
Nov 15, 2023
| @@ -185,6 +185,15 @@ def source(self): | |||
| assert f"Sources for {self.file_server.fake_url}/internet/myfile.txt found in remote backup" in self.client.out | |||
| assert f"File {self.file_server.fake_url}/mycompanystorage/mycompanyfile.txt not found in {self.file_server.fake_url}/backups/" in self.client.out | |||
|
|
|||
| # Ensure defaults backup folder works if nothing set in global.conf | |||
There was a problem hiding this comment.
Not sure if I understand the comment, you say nothing in the global.conf, then define the global.conf? 😅
| @@ -24,6 +24,7 @@ def __init__(self, conanfile): | |||
| self._cache = helpers.cache | |||
| self._output = conanfile.output | |||
| self._conanfile = conanfile | |||
| self._cache_folder = helpers.cache.cache_folder | |||
There was a problem hiding this comment.
Why not using self._cache.cache_folder below?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Fix backup sources error when no
core.sources:download_cacheis set.Docs: Omit
The tests were unfortunately not covering that case
Closes #15103