fix recreation of same package revision #14938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbrilRBS
approved these changes
Oct 16, 2023
| layout._base_folder = pkg_layout.base_folder # reuse existing one | ||
| # TODO: The relpath would be the same as the previous one, it shouldn't be ncessary to | ||
| # update it, the update_package_timestamp() can be simplified and path dropped | ||
| relpath = os.path.relpath(layout.base_folder, self._base_folder) |
There was a problem hiding this comment.
I have little insight into why this is needed again given the conext of the comment above, I'll trust you on this one but maybe I just need to look deeper into this bit of code functionality
czoido
approved these changes
Oct 17, 2023
franramirez688
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Solve re-build of an existing package revision (like forcing rebuild of a an existing header-only package), while previous folder was still used by other projects.
Docs: Omit
Close #14933