Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clang 17 to conan 1 #14915

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

vok1980
Copy link
Contributor

@vok1980 vok1980 commented Oct 12, 2023

Changelog: Feature: Add clang-17 support to settings.
Docs: conan-io/docs#3447

fixes #14914
See no need to modify docs here.

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

@CLAassistant
Copy link

CLAassistant commented Oct 12, 2023

CLA assistant check
All committers have signed the CLA.

@vok1980 vok1980 force-pushed the feature/add-clang-17-to-conan-1 branch from a290c41 to 8f5d3ee Compare October 12, 2023 04:52
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, this will be in the next 1.X release.
Recall that meanwhile until the release you can add it yourself to your settings.yml that you can install with conan config install.

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I realized that this might need something more, as clang 17 has c++23 support.
Check https://github.com/conan-io/conan/pull/14781/files by @RubenRBS, this would be needed here too. Thanks!

@memsharded memsharded added this to the 1.62 milestone Oct 12, 2023
@vok1980 vok1980 force-pushed the feature/add-clang-17-to-conan-1 branch from f9b80e8 to 88e43a1 Compare October 12, 2023 10:20
@vok1980 vok1980 requested a review from memsharded October 12, 2023 12:13
@memsharded memsharded merged commit e992ec6 into conan-io:develop Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants