-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shorthand syntax in cli to specify host and build in 1 argument #14727
Merged
czoido
merged 18 commits into
conan-io:release/2.0
from
AbrilRBS:rr/shorthand-cli-host&build
Oct 18, 2023
Merged
Changes from 12 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
ae1017c
Add shorthand for passing install args to both host & build context
AbrilRBS 130d3cd
Add shorthand test
AbrilRBS f0cd841
Fix tests
AbrilRBS 0edf79d
Try workaround for global.conf all profile
AbrilRBS ce2cc17
Only modify settings, no need to compose new profiles
AbrilRBS ed5e443
Merge branch 'release/2.0' into rr/shorthand-cli-host&build
AbrilRBS 920692a
Improve profiles args help messages
AbrilRBS dd17060
Nicer python-fu
AbrilRBS 3dbe945
Compromise between every possible option
AbrilRBS 9f88bf6
Remove sketch test for unrelated bug
AbrilRBS c92bdc4
Better shorthand handling
AbrilRBS e7852f4
Tests!
AbrilRBS b273c2c
Merge branch 'release/2.0' into rr/shorthand-cli-host&build
AbrilRBS 6b63160
Remove unrelated test
AbrilRBS e7b4f40
Simplify code
AbrilRBS bf1af93
Fix tests
AbrilRBS 853c529
Show that mixing and matching works as expected
AbrilRBS 2d9c06d
Merge branch 'release/2.0' into rr/shorthand-cli-host&build
memsharded File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably args/kwargs can be used to simplify code, both here and in
super()
codeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish the append Action was public in argparse, so this could be
but alas