Add SConsDeps generator #14713
Merged
Add SConsDeps generator #14713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
approved these changes
Sep 11, 2023
conan/tools/scons/sconsdeps.py
Outdated
| }, | ||
| {% if dep_version is not none %}"{{dep_name}}_version" : "{{dep_version}}",{% endif %} | ||
| """) | ||
| sections = ["conan = {\n"] |
There was a problem hiding this comment.
Wasn't the section called conandeps? (to account for a potential conantoolchain)
There was a problem hiding this comment.
Right now, as it is is this:
# SConscript_conandeps generated by conan
conan = {
# this one aggregates all libs
"conandeps" : {
"CPPPATH" ...
},
# now separate libs
"zlib" : {
"CPPPATH" ...
},
"zlib_version" ...
...
loaded like this in the SConscript:
# SConscript by the consumer
conan = SConscript('./SConscript_conandeps')
flags = conan["conandeps"]
env.MergeFlags(flags)
Maybe we can do:
conandeps = {
# this one aggregates all libs
"conanlibs" : { # all_libs? aggregated_libs?...
"CPPPATH" ...
},
...
then:
conan = SConscript('./SConscript_conandeps')
flags = conandeps["conanlibs"]
env.MergeFlags(flags)
Something like that?
memsharded
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Add SConsDeps generator.
Docs: conan-io/docs#3371
Related to: #14717
Functional tests only for Linux