Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix conan 1.x: consider revision for build_requires #14679

Merged
merged 1 commit into from
Sep 7, 2023
Merged

bugfix conan 1.x: consider revision for build_requires #14679

merged 1 commit into from
Sep 7, 2023

Conversation

thorsten-klein
Copy link
Contributor

@thorsten-klein thorsten-klein commented Sep 6, 2023 •
edited by czoido
Loading

Changelog: Bugfix: Consider revision for build_requires in cli arguments.
Docs: Omit

This solves #14678

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.

@thorsten-klein thorsten-klein changed the base branch from release/1.60 to develop September 6, 2023 07:32
memsharded
memsharded reviewed Sep 6, 2023
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @thorsten-klein

This seems indeed an issue, and the fix looks correct.
Would be great to have a unit test that covers the fix, if you can add it, please do, otherwise don't worry, we will add it.

Assigning it for next 1.61 release

@memsharded memsharded added this to the 1.61 milestone Sep 6, 2023
@thorsten-klein
Copy link
Contributor Author

I have added some test for it now 😊

memsharded
memsharded approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@memsharded memsharded merged commit bb35ee8 into conan-io:develop Sep 7, 2023
@memsharded memsharded mentioned this pull request Sep 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.61
Development

Successfully merging this pull request may close these issues.
2 participants
@thorsten-klein @memsharded