-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow settings_target across compatibility method #14532
Allow settings_target across compatibility method #14532
Conversation
In the info.py module, following the guidance provided in the comments for the settings_target property, this commit focuses on refining the handling of settings_target within various package methods. When populating the settings_target property via the package_id() method, the adjustment guarantees that it remains accessible to both the info and original_info methods. By extending its accessibility to these methods, it allows for seamless utilization within the compatibility() method as well. Signed-off-by: Adnan Ali <m_adnanali_1@hotmail.com>
f46ad31
to
1a20b3b
Compare
Signed-off-by: Adnan Ali <m_adnanali_1@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for the contribution @adnan-ali1
I think this is looking good overall, but it might still need some improvement and some other extra tests, please let us know if the comments are enough or you'd like some help with that.
@memsharded thanks for the review. I will update the PR with the proposed changes |
Prevents the crash as in case a requirements is not build as a build_require it does not even has a settings_target and settings some property in null object would crash. Update test cases to check for multiple scenerios: Signed-off-by: Adnan Ali <m_adnanali_1@hotmail.com>
take in the suggestion. Co-authored-by: James <memsharded@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are good, and tests are clean and comprehensive, great job, thanks very much!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adnan-ali1 thanks a lot for your contribution, it's really appreciated!
I like the simplicity of adding this feature and the tests you provided are quite comprehensive :)
Changelog: Feature: Allow access to
settings_target
in compatibility method.Docs: Omit
Closes #14527
In the info.py module, following the guidance provided in the comments for the settings_target property, this commit focuses on refining the handling of settings_target within various package methods.
When populating the settings_target property via the package_id() method, the adjustment guarantees that it remains accessible to both the info and original_info methods. By extending its accessibility to these methods, it allows for seamless utilization within the compatibility() method as well.
develop
branch, documenting this one.Test Case Result
Before
After