Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid passing compiler options into rc.exe #14378

Conversation

BobIsOnFire
Copy link
Contributor

@BobIsOnFire BobIsOnFire commented Jul 26, 2023

Changelog: Fix: MSBuildToolchain/MSBuildDeps: Avoid passing C/C++ compiler options as options for ResourceCompile.
Docs: omit

Fixes #12819.

See my #12819 (comment).

More details: ResourceCompile is executed via rc.exe, which shares preprocessor flags with cl.exe (i.e. AdditionalIncludeDirectories and PreprocessorDefinitions in MSBuild terms), but set of compile options is completely different from cl.exe, so it looks wrong to add them here.

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.

@memsharded memsharded added this to the 2.0.10 milestone Jul 29, 2023
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for the investigation and the fix, I think this makes sense, lets merge it for next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] RC : fatal error RC1212: invalid option - /z argument missing substitute font name
2 participants