Avoid passing compiler options into rc.exe #14378
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix:
MSBuildToolchain
/MSBuildDeps
: Avoid passing C/C++ compiler options as options forResourceCompile
.Docs: omit
Fixes #12819.
See my #12819 (comment).
More details:
ResourceCompile
is executed viarc.exe
, which shares preprocessor flags withcl.exe
(i.e.AdditionalIncludeDirectories
andPreprocessorDefinitions
in MSBuild terms), but set of compile options is completely different fromcl.exe
, so it looks wrong to add them here.