detect msvc and version when CC/CXX point to cl.exe #14364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcar87
commented
Jul 25, 2023
memsharded
approved these changes
Aug 1, 2023
Oops, should have taken it out of draft already :D will merge once CI reports a pass (I think changing it to not-a-draft restarted a build). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature:
conan profile detectcan now detect the version of msvc when invoked within a Visual Studio prompt whereCCorCXXare defined and pointing to theclcompiler executableDocs: Omit
This PR fixes issue where
conan profile detectis invoked from an active Visual Studio prompt that also happens to haveCCorCXXdefined. This may be unusual for a developer to actively configure a prompt like this, but Visual Studio invoke may invoke CMake in such an environment, and this may cause issues ifconan profile detectneeds to run when usingcmake-conan.This assumes that
cl.exe /?always prints the copyright and the version in the first line. It doesn't assume a specific text since it can be localized to different languages, but it does assume that the string containsMicrosoftand that the version contains 3 or more components. We also avoid running this logic ifclangis part of the string - e.g.clang-clwould not be handled and would fall back to the current behaviour.Tests cover defining
CCin multiple ways, e.g.clandcl.exe(falls back to finding it in PATH), or the full path tocl.exe, which may be surrounded in double quotes as the path is very likely to contain spaces if it's installed in the default location.