fix default_options propagation to test_requires/tool_requires #14340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Correctly propagate options defined in recipe
default_optionstotest_requires.Changelog: Feature: Provide new
default_build_optionsattribute for defining options fortool_requiresin recipes.Docs: conan-io/docs#3338
Close #14280
Close #13414
One extra data point:
test_requires()thedefault_options. This PR aligns this behaviortool_requires()thedefault_options. This PR introduces thedefault_build_options, as an alternative way to clearly define the intention.Do we want to fully align with 1.X behavior and consider the current 2.0.9 behavior a bug for
tool_requires?