Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trying abs path for config install #14183

Merged
merged 4 commits into from
Aug 21, 2023
Merged

trying abs path for config install #14183

merged 4 commits into from
Aug 21, 2023

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Jun 28, 2023 •
edited by czoido
Loading

Changelog: Fix: Use abspath for conan config install to avoid symlinks issues.
Docs: Omit

This will probably FAIL in OSX, it needs to be the realpath.

Close #14178

@memsharded memsharded mentioned this pull request Jun 28, 2023
Closed
@memsharded memsharded added this to the 2.0.8 milestone Jun 28, 2023
@memsharded memsharded modified the milestones: 2.0.8, 2.0.9 Jul 11, 2023
@memsharded memsharded modified the milestones: 2.0.9, 2.0.10 Jul 19, 2023
@memsharded memsharded marked this pull request as ready for review August 20, 2023 21:58
AbrilRBS
AbrilRBS approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works good on my end when installing from /var/..., both locally and after modifying the test

@AbrilRBS AbrilRBS merged commit 1d449da into conan-io:release/2.0 Aug 21, 2023
@memsharded memsharded deleted the fix/config_install_abs_path branch August 21, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS approved these changes

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
2.0.10
Development

Successfully merging this pull request may close these issues.

[bug] conan config install does not work on mounted network drives on Windows
2 participants
@memsharded @AbrilRBS