global cpp_info can be used to initialize components #13994
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
commented
May 29, 2023
| @@ -572,6 +572,8 @@ def package_info(self): | |||
| self.cpp_info.set_property("pkg_config_name", "pkg_other_name") | |||
| self.cpp_info.set_property("pkg_config_aliases", ["pkg_alias1", "pkg_alias2"]) | |||
| self.cpp_info.components["cmp1"].libs = ["libcmp1"] | |||
| self.cpp_info.components["cmp1"].libdirs = ["lib"] | |||
There was a problem hiding this comment.
These tests were ill-formed in the first place, because they were defining things that doesn't work. Yes, they are serialized, but most generators just discard the global cpp_info definition.
memsharded
commented
May 29, 2023
| @@ -32,6 +32,7 @@ def build(self): | |||
|
|
|||
| def layout(self): | |||
| cmake_layout(self, src_folder="src") | |||
| self.cpp.source.includedirs = [] | |||
There was a problem hiding this comment.
It is important to invalidate the non-existing includedirs in conanfile.cpp.source.includedirs = ["include"] inside cmake_layout()
|
This is too risky, better wait until |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Global
cpp_infocan be used to initialize components values.Docs: omit
This is a long standing issue, where users that define
self.cpp_info.includedirs = ["myinclude"]are surprised that individual components will not use themyincludefolder too.There could be different approaches to this, I have implemented the following:
cpp_infoself.cpp_infoare not taken into account.