CMakeDeps: do not print warnings when alias targets already defined #13527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I've also faced with this issue. |
|
closed in favour of #14644 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Remove warnings from defined alias targets in CMakeDeps in case the generated files are processed twice
Docs: Omit
When targets are created with
add_libraryduring the workflow offind_package(either when processing aXXX-config.cmakefile orFindXXX.cmakeone), it is entirely possible (and valid) that the file is processed twice - so it is customary to guard the call toadd_librarywithif (NOT TARGET...).What's unusual is to print a warning if the target was already defined - especially a regular warning that the consumers cannot do anything about.
This PR aligns these calls with every other invocation of
add_librarywithin theCMakeDepsgenerator - none of the others have a warning in this instance.