-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boost: compiler=msvc support + bump dependencies #9790
Conversation
I detected other pull requests that are modifying boost/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
}.get(str(self.settings.compiler), str(self.settings.compiler)) | ||
if (self.settings.compiler, self.settings.os) == ("gcc", "Windows"): | ||
compiler = "mgw" | ||
os_ = "" | ||
if self.settings.os == "Macos": | ||
os_ = "darwin" | ||
toolset_version = str(tools.Version(self.settings.compiler.version).major) | ||
if str(self.settings.compiler) in ("msvc", "Visual Studio"): | ||
if self._is_msvc: | ||
toolset_version = self._toolset_version.replace(".", "") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_toolset_version()
relies on tools.msvs_toolset()
which doesn't support compiler=msvc
, but I don't see a similar function in conan.tools.microsoft
(I see something in MSBuildToolchain
but I'm a little bit reluctant to instantiate this class just to get toolset version).
/cc @memsharded @lasote
All green in build 1 (
|
other minor modifications:
ConanInvalidConfiguration
fromconfigure()
tovalidate()
conan.tools.files.rename()
instead oftools.rename()
conan-center hook activated.