-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enjincppsdk recipe #9565
Add enjincppsdk recipe #9565
Conversation
This comment has been minimized.
This comment has been minimized.
- Moved minimum C++ version check from `validate()` method to `configure()`
This comment has been minimized.
This comment has been minimized.
- Replaced dependency option override with validation checks
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
might be a conan client bug. some configurations computed package ID as
|
After having a look at it together with @SSE4 , we have realized it is a side-effect of the Of course, in CCI the dependencies are already available, but we are using We can fix it in the library if we run first |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
project(cmake_wrapper) | ||
|
||
include(conanbuildinfo.cmake) | ||
conan_basic_setup() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conan_basic_setup() | |
conan_basic_setup(KEEP_RPATH) |
Better compatibility on Mac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for clarification, is it KEEP_RPATH
or KEEP_RPATHS
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ops, it was a typo indeed, it's KEEP_RPATHS
https://docs.conan.io/en/latest/reference/generators/cmake.html#conan-basic-setup
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The CI hasn't progressed for the last few hours, is something wrong? |
Nope, just it's more busy than usual. You PR is building right now. |
For the Jenkins CI, I get a |
We have had an issue with the CI during the weekend (it always breaks on weekends 😓 ). I've triggered it again manually. The CI instance is private, but the bot should post all the relevant information once it finishes. Thanks! |
This comment has been minimized.
This comment has been minimized.
All green in build 17 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Specify library name and version: enjincppsdk/1.0.0-alpha.3
This introduces the Enjin C++ SDK (https://github.com/enjin/enjin-cpp-sdk) as a recipe. The SDK supports development of blockchain games on the Enjin platform.
conan-center hook activated.