Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enjincppsdk recipe #9565

Merged
merged 23 commits into from
May 10, 2022
Merged

Add enjincppsdk recipe #9565

merged 23 commits into from
May 10, 2022

Conversation

BishopJohnson
Copy link
Contributor

Specify library name and version: enjincppsdk/1.0.0-alpha.3

This introduces the Enjin C++ SDK (https://github.com/enjin/enjin-cpp-sdk) as a recipe. The SDK supports development of blockchain games on the Enjin platform.


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@CLAassistant
Copy link

CLAassistant commented Mar 2, 2022

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

- Moved minimum C++ version check from `validate()` method to `configure()`
@conan-center-bot

This comment has been minimized.

- Replaced dependency option override with validation checks
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@SSE4
Copy link
Contributor

SSE4 commented Mar 3, 2022

might be a conan client bug. some configurations computed package ID as Package_ID_unknown. I am taking a look.

enjincppsdk/1.0.0-alpha.3 |                DUPLICATED |                         Package_ID_unknown |      Linux
enjincppsdk/1.0.0-alpha.3 |                DUPLICATED |                         Package_ID_unknown |      Linux
enjincppsdk/1.0.0-alpha.3 |                DUPLICATED |                         Package_ID_unknown |      Linux
enjincppsdk/1.0.0-alpha.3 |                DUPLICATED |                         Package_ID_unknown |      Linux
enjincppsdk/1.0.0-alpha.3 |                DUPLICATED |                         Package_ID_unknown |      Linux
enjincppsdk/1.0.0-alpha.3 |                DUPLICATED |                         Package_ID_unknown |      Linux
enjincppsdk/1.0.0-alpha.3 |                DUPLICATED |                         Package_ID_unknown |      Linux
enjincppsdk/1.0.0-alpha.3 |        UPSTREAM + TEST_OK |   b88c6c28c0c0371b75eec2425d4710f4e15695e0 |      Linux
enjincppsdk/1.0.0-alpha.3 |        UPSTREAM + TEST_OK |   930eb4fc2e4931bbf775269eb65cf89d227feb4e |      Linux
enjincppsdk/1.0.0-alpha.3 |           BUILT + TEST_OK |   90885c0ac1c54143c692fd3ce557d14ed6b8adfa |      Linux
enjincppsdk/1.0.0-alpha.3 |           BUILT + TEST_OK |   8c9282b41bb7d57a58effa938fa5ffd41abf2462 |      Linux
enjincppsdk/1.0.0-alpha.3 |           BUILT + TEST_OK |                         Package_ID_unknown |      Linux

@SSE4 SSE4 added the infrastructure Waiting on tools or services belonging to the infra label Mar 3, 2022
@jgsogo
Copy link
Contributor

jgsogo commented Mar 3, 2022

After having a look at it together with @SSE4 , we have realized it is a side-effect of the shared_library_package_id. That shared_library_package_id activates a full_package_revision for its dependencies, so it cannot compute the pkg-id until those dependencies are being built.

Of course, in CCI the dependencies are already available, but we are using conan info --dry-build to compute the package-id and to get all the requirements (also the build requirements) with the same command. Using --dry-build makes Conan works as if the binaries were not available. Consequence: we get pkg-unknown.

We can fix it in the library if we run first conan info to get the pkg-id and then conan info --dry-build to get the requirements. I'm adding this to the backlog, but it will take us some days until we deploy it to prod.

@conan-center-bot

This comment has been minimized.

@SSE4 SSE4 removed the infrastructure Waiting on tools or services belonging to the infra label Mar 9, 2022
@conan-center-bot

This comment has been minimized.

recipes/enjincppsdk/all/conanfile.py Outdated Show resolved Hide resolved
project(cmake_wrapper)

include(conanbuildinfo.cmake)
conan_basic_setup()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
conan_basic_setup()
conan_basic_setup(KEEP_RPATH)

Better compatibility on Mac

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for clarification, is it KEEP_RPATH or KEEP_RPATHS?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recipes/enjincppsdk/all/conanfile.py Outdated Show resolved Hide resolved
recipes/enjincppsdk/all/conanfile.py Outdated Show resolved Hide resolved
recipes/enjincppsdk/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@BishopJohnson
Copy link
Contributor Author

The CI hasn't progressed for the last few hours, is something wrong?

@uilianries
Copy link
Member

The CI hasn't progressed for the last few hours, is something wrong?

Nope, just it's more busy than usual. You PR is building right now.

@BishopJohnson
Copy link
Contributor Author

For the Jenkins CI, I get a 403 when trying to view the details, is that check failing due to the recipe? Also, I noticed the steps for Windows and MacOS didn't run this time around.

@jgsogo
Copy link
Contributor

jgsogo commented May 9, 2022

We have had an issue with the CI during the weekend (it always breaks on weekends 😓 ). I've triggered it again manually.

The CI instance is private, but the bot should post all the relevant information once it finishes.

Thanks!

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

All green in build 17 (3d137662a004abe917edd3de92afe1d9b5ed710b):

  • enjincppsdk/1.0.0-alpha.5@:
    All packages built successfully! (All logs)

@SSE4 SSE4 requested a review from uilianries May 10, 2022 07:36
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 84cc4af into conan-io:master May 10, 2022
@BishopJohnson BishopJohnson deleted the package-enjincppsdk branch May 23, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants