Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cctag/1.0.1 #9478

Merged
merged 6 commits into from
Mar 10, 2022
Merged

add cctag/1.0.1 #9478

merged 6 commits into from
Mar 10, 2022

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Feb 22, 2022

This library depends on Boost Math.
Therefore it won't build out of the box in conan-center if default C++ standard of the compiler is not at least C++11.
Why?

  • Boost Math requires C++11
  • Boost recipe is not modularized
  • Few components (not related to Math component) of Boost have API/ABI breakage depending on C++ standard
    => In consequence, unlike current "policy" of all other conan-center recipes, boost recipe doesn't build C++11 components if compiler.cppstd is not explicitly set to 11 or higher, or if default C++ standard of the compiler is not 11 or higher.

Since default C++ standard of apple-clang is still C++98 => no build for macOS in CCI.


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

jgsogo
jgsogo previously approved these changes Feb 23, 2022
@conan-center-bot

This comment has been minimized.

uilianries
uilianries previously approved these changes Mar 2, 2022
@conan-center-bot
Copy link
Collaborator

All green in build 6 (44238a012503d334fcb989082f7ce743ef64889a):

  • cctag/1.0.1@:
    All packages built successfully! (All logs)

@SpaceIm SpaceIm requested a review from uilianries March 4, 2022 12:05
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice!

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Mar 9, 2022

auto merge seems to be broken, and @uilianries and @SSE4 are not gods anymore 👶

@SSE4
Copy link
Contributor

SSE4 commented Mar 10, 2022

auto merge seems to be broken, and @uilianries and @SSE4 are not gods anymore 👶

automatic merge is working again, just merged #9335. thanks for your patience!

@conan-center-bot conan-center-bot merged commit 2c17793 into conan-io:master Mar 10, 2022
@SpaceIm SpaceIm deleted the new/cctag/1.0.1 branch March 10, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants