-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libvpx: fix Visual Studio 2022 build + modernize #9467
Conversation
This comment has been minimized.
This comment has been minimized.
c47e400
to
c7e3edd
Compare
This comment has been minimized.
This comment has been minimized.
c7e3edd
to
9f85b6e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hidden issue for Visual Studio (seen in test package):
Comes from https://github.com/webmproject/libvpx/blob/8a50f70ffc5eea6c2392a5c176bfe43e450ecebc/build/make/gen_msvs_vcxproj.sh#L351-L353 I guess. |
This comment has been minimized.
This comment has been minimized.
c0f6328
to
543c646
Compare
Ok, looks good regarding /GL now. There is still a runtime inconsistency in msvc debug builds, and I think it's the reason of the failures in #9624: test package:
Indeed during libvpx build, here the compile command of one of the compilation units:
So what happen here? libvpx builds both Release & Debug. But install target seems to install Release only, regardless of build_type. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
implementation is in C also, except one compilation unit in C++, so we keep compiler.libcxx & compiler.cppstd
f1a9e8e
to
9e9e064
Compare
also honor upstream lib name
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
a05a721
to
d8aeb44
Compare
closes #8319
conan-center hook activated.