Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#9407) [gdal] fix podofo include #9416

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

zjg
Copy link
Contributor

@zjg zjg commented Feb 17, 2022

Specify library name and version: gdal/3.1.0

Fixes #9407


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@CLAassistant
Copy link

CLAassistant commented Feb 17, 2022

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor

SpaceIm commented Feb 17, 2022

And other versions? Because this issue is still there in master: https://github.com/OSGeo/gdal/blob/d21b787e29947fe453a8aa9848386e4c65a6fbb1/frmts/pdf/pdfsdk_headers.h#L107

@ghost
Copy link

ghost commented Feb 17, 2022

I detected other pull requests that are modifying gdal/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@zjg
Copy link
Contributor Author

zjg commented Feb 17, 2022

And other versions? Because this issue is still there in master: https://github.com/OSGeo/gdal/blob/d21b787e29947fe453a8aa9848386e4c65a6fbb1/frmts/pdf/pdfsdk_headers.h#L107

I tried to check the newer versions, but I don't have VS 2019 set up on my machine currently, so I just submitted a PR for the 3.1.x versions. The patch is likely the same/similar for the newer versions, but I can't verify it myself:

gdal/3.2.1: Invalid ID: Visual Studio < 2019 not yet supported in this recipe for gdal 3.2.1

@zjg zjg changed the title (#9407) [gdal/3.1.0] fix podofo include (#9407) [gdal/3.1.x] fix podofo include Feb 17, 2022
@ghost ghost mentioned this pull request Mar 3, 2022
4 tasks
@zjg zjg force-pushed the fix-gdal-podofo-includes branch from bde2558 to d2b994f Compare March 11, 2022 21:28
@zjg
Copy link
Contributor Author

zjg commented Mar 11, 2022

I have successfully built GDAL with the patch for the 4 active versions, using compiler.version=14

@zjg zjg changed the title (#9407) [gdal/3.1.x] fix podofo include (#9407) [gdal] fix podofo include Mar 11, 2022
@ghost ghost mentioned this pull request Mar 13, 2022
4 tasks
@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor

SpaceIm commented Mar 15, 2022

@zjg you should request an access: #4

@conan-center-bot
Copy link
Collaborator

All green in build 4 (d2b994f9e66cda34074d73709488d24163eacaf8):

  • gdal/3.2.3@:
    All packages built successfully! (All logs)

  • gdal/3.3.3@:
    All packages built successfully! (All logs)

  • gdal/3.1.4@:
    All packages built successfully! (All logs)

  • gdal/3.4.1@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 1e295a3 into conan-io:master Mar 21, 2022
@zjg zjg deleted the fix-gdal-podofo-includes branch March 23, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] gdal/3.1.0: does not compile with option with_podofo=True
6 participants