Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fusepp by jachappell/Fusepp #9310

Merged
merged 17 commits into from
Mar 1, 2022
Merged

Conversation

winternet
Copy link
Contributor

@winternet winternet commented Feb 8, 2022

Specify library name and version: fusepp/3.0.0


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@CLAassistant
Copy link

CLAassistant commented Feb 8, 2022

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Thanks for sharing this really cool library!

We typically do not add forks as they are harder for us to maintain.

In this particular case I think we can avoid it

If you need more help, feel free to @ me 😄

@prince-chrismc
Copy link
Contributor

Also I;d suggest you open a PR against the upstream repo to share your work 🙏

@conan-center-bot

This comment has been minimized.

@winternet
Copy link
Contributor Author

Hi, makes sense - thanks for your feedback! I adapted the package accordingly.

wave Thanks for sharing this really cool library!

We typically do not add forks as they are harder for us to maintain.

In this particular case I think we can avoid it

If you need more help, feel free to @ me smile

recipes/fusepp/all/CMakeLists.txt Outdated Show resolved Hide resolved
recipes/fusepp/all/conanfile.py Outdated Show resolved Hide resolved
recipes/fusepp/all/conanfile.py Outdated Show resolved Hide resolved
recipes/fusepp/all/conanfile.py Show resolved Hide resolved
recipes/fusepp/all/conanfile.py Show resolved Hide resolved
winternet and others added 5 commits February 15, 2022 17:30
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@uilianries
Copy link
Member

Simplify the test package to a single and very simple cpp file. The idea is testing library linkage, not run an example or unit tests. Take a look on others recipes in Conan Center Index.

@conan-center-bot

This comment has been minimized.

SSE4
SSE4 previously approved these changes Feb 21, 2022
@SSE4 SSE4 requested a review from uilianries February 21, 2022 07:21
recipes/fusepp/all/test_package/conanfile.py Outdated Show resolved Hide resolved
recipes/fusepp/all/test_package/conanfile.py Outdated Show resolved Hide resolved
recipes/fusepp/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved
recipes/fusepp/all/conanfile.py Show resolved Hide resolved
@conan-center-bot
Copy link
Collaborator

All green in build 17 (855a367d0eae5e19c4b0090deabd7e2bf9e12d85):

  • fusepp/cci.20210820@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 59d90d1 into conan-io:master Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants