-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add fusepp by jachappell/Fusepp #9310
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Thanks for sharing this really cool library!
We typically do not add forks as they are harder for us to maintain.
In this particular case I think we can avoid it
- For the version checkout https://github.com/conan-io/conan-center-index/blob/master/docs/faqs.md#what-version-should-packages-use-for-libraries-without-official-releases
- For the CMake checkout: https://github.com/conan-io/conan-center-index/blob/master/docs/how_to_add_packages.md#no-upstream-build-scripts
If you need more help, feel free to @ me 😄
Also I;d suggest you open a PR against the upstream repo to share your work 🙏 |
This comment has been minimized.
This comment has been minimized.
Hi, makes sense - thanks for your feedback! I adapted the package accordingly.
|
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Simplify the test package to a single and very simple cpp file. The idea is testing library linkage, not run an example or unit tests. Take a look on others recipes in Conan Center Index. |
This comment has been minimized.
This comment has been minimized.
All green in build 17 (
|
Specify library name and version: fusepp/3.0.0
conan-center hook activated.