Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a with_extras option to the ICU package #9299

Merged
merged 2 commits into from
Feb 14, 2022

Conversation

datalogics-robb
Copy link
Contributor

ICU is configured with --disable-extras by default, and this PR makes
it possible to turn it on with the option "icu:with_extras=True".

Specify library name and version: icu/70.1 (and earlier)

ICU's configure script will enable this option by default, which will create the "uconv" command-line tool
for doing text conversions. This option preserves the current behavior by defaulting to "False" but allows it to be turned on explicitly.


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

ICU is configured with --disable-extras by default, and this commit makes
it possible to turn it on with the option "icu:with_extras=True".
@conan-center-bot

This comment has been minimized.

toge
toge previously approved these changes Feb 8, 2022
@SpaceIm
Copy link
Contributor

SpaceIm commented Feb 8, 2022

ICU's configure script will enable this option by default, which will create the "uconv" command-line tool
for doing text conversions. This option preserves the current behavior by defaulting to "False" but allows it to be turned on explicitly.

Therefore in package_info(), you should replace:

            bin_path = os.path.join(self.package_folder, "bin")
            self.output.info("Appending PATH environment variable: {}".format(bin_path))
            self.env_info.PATH.append(bin_path)

by

        if self._enable_icu_tools or self.options.with_extras:
            bin_path = os.path.join(self.package_folder, "bin")
            self.output.info("Appending PATH environment variable: {}".format(bin_path))
            self.env_info.PATH.append(bin_path)

and

            if self._enable_icu_tools:
                self.buildenv_info.prepend_path("ICU_DATA", data_path)

by

            if self._enable_icu_tools or self.options.with_extras:
                self.buildenv_info.prepend_path("ICU_DATA", data_path)

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@datalogics-robb
Copy link
Contributor Author

I can't see what it thinks is wrong here - was it a problem with CI or with the code in the PR?

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor

SpaceIm commented Feb 12, 2022

I can't see what it thinks is wrong here - was it a problem with CI or with the code in the PR?

CI issue. Close/Open until it works.

@conan-center-bot
Copy link
Collaborator

All green in build 5 (009cf3285eb6e6be762265d7416cf1521a204a33):

  • icu/65.1@:
    All packages built successfully! (All logs)

  • icu/64.2@:
    All packages built successfully! (All logs)

  • icu/67.1@:
    All packages built successfully! (All logs)

  • icu/68.1@:
    All packages built successfully! (All logs)

  • icu/70.1@:
    All packages built successfully! (All logs)

  • icu/69.1@:
    All packages built successfully! (All logs)

  • icu/66.1@:
    All packages built successfully! (All logs)

  • icu/68.2@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 8d7a98e into conan-io:master Feb 14, 2022
SSE4 pushed a commit to madebr/conan-center-index that referenced this pull request Feb 21, 2022
* Add a with_extras option to the ICU package

ICU is configured with --disable-extras by default, and this commit makes
it possible to turn it on with the option "icu:with_extras=True".

* Gate environment settings on the options that need them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants