-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a with_extras option to the ICU package #9299
Conversation
ICU is configured with --disable-extras by default, and this commit makes it possible to turn it on with the option "icu:with_extras=True".
This comment has been minimized.
This comment has been minimized.
Therefore in bin_path = os.path.join(self.package_folder, "bin")
self.output.info("Appending PATH environment variable: {}".format(bin_path))
self.env_info.PATH.append(bin_path) by if self._enable_icu_tools or self.options.with_extras:
bin_path = os.path.join(self.package_folder, "bin")
self.output.info("Appending PATH environment variable: {}".format(bin_path))
self.env_info.PATH.append(bin_path) and if self._enable_icu_tools:
self.buildenv_info.prepend_path("ICU_DATA", data_path) by if self._enable_icu_tools or self.options.with_extras:
self.buildenv_info.prepend_path("ICU_DATA", data_path) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I can't see what it thinks is wrong here - was it a problem with CI or with the code in the PR? |
This comment has been minimized.
This comment has been minimized.
CI issue. Close/Open until it works. |
All green in build 5 (
|
* Add a with_extras option to the ICU package ICU is configured with --disable-extras by default, and this commit makes it possible to turn it on with the option "icu:with_extras=True". * Gate environment settings on the options that need them.
ICU is configured with --disable-extras by default, and this PR makes
it possible to turn it on with the option "icu:with_extras=True".
Specify library name and version: icu/70.1 (and earlier)
ICU's configure script will enable this option by default, which will create the "uconv" command-line tool
for doing text conversions. This option preserves the current behavior by defaulting to "False" but allows it to be turned on explicitly.
conan-center hook activated.