qhull: relocatable shared libs on macOS #9279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
SSE4
reviewed
Feb 21, 2022
| @@ -22,14 +22,14 @@ | |||
| - set(qhull_STATICR qhullstatic_r) | |||
| -endif() | |||
| +include_directories(${CMAKE_CURRENT_SOURCE_DIR}/src) | |||
| + | |||
| +set(qhull_CPP qhullcpp) | |||
There was a problem hiding this comment.
does it really need a patch? can we set these qhull_* variables from the outside (via cmake -Dqhull_CPP=whatver ...)?
There was a problem hiding this comment.
this part of the patch for old versions is not new. it is required. Basically it's part of 8.0.2 and master: qhull/qhull#76
This comment has been minimized.
This comment has been minimized.
SSE4
approved these changes
Mar 13, 2022
prince-chrismc
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see conan-io/hooks#376
conan-center hook activated.