Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-sdk-cpp] Add s3-crt component #9248

Merged
merged 2 commits into from
Feb 14, 2022

Conversation

jeremy-coulon
Copy link
Contributor

@jeremy-coulon jeremy-coulon commented Feb 3, 2022

Specify library name and version: aws-sdk-cpp/1.9

aws-sdk-cpp v1.9 introduced a new component called s3-crt
This component is missing from conan recipe.


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@ghost
Copy link

ghost commented Feb 3, 2022

I detected other pull requests that are modifying aws-sdk-cpp/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor

SpaceIm commented Feb 3, 2022

aws-sdk-cpp v1.9 introduced a new component called s3-crt

Therefore this option should be deleted in config_options() if version is lower than 1.9

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

All green in build 3 (065417f12a3c982e2baa5d4493b03607b4a99660):

  • aws-sdk-cpp/1.8.130@:
    All packages built successfully! (All logs)

  • aws-sdk-cpp/1.9.100@:
    All packages built successfully! (All logs)

@jeremy-coulon
Copy link
Contributor Author

aws-sdk-cpp v1.9 introduced a new component called s3-crt

Therefore this option should be deleted in config_options() if version is lower than 1.9

Done. Thank you for feedback.

@conan-center-bot conan-center-bot merged commit cf21126 into conan-io:master Feb 14, 2022
@jeremy-coulon jeremy-coulon deleted the aws-s3-crt branch February 14, 2022 13:38
SSE4 pushed a commit to madebr/conan-center-index that referenced this pull request Feb 21, 2022
* [aws-sdk-cpp] Add s3-crt component

* [aws-sdk-cpp] s3-crt only for version >= 1.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants