Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libtins: fix CMake imported target + fix windows build + modernize #9239

Merged
merged 6 commits into from
Feb 16, 2022
Merged

libtins: fix CMake imported target + fix windows build + modernize #9239

merged 6 commits into from
Feb 16, 2022

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Feb 3, 2022 •
edited
Loading

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@prince-chrismc prince-chrismc mentioned this pull request Feb 3, 2022
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@SpaceIm
Copy link
Contributor Author

SpaceIm commented Feb 3, 2022

Waiting for #9249 before moving on.

@SpaceIm SpaceIm changed the title libtins: fix CMake imported target + modernize libtins: fix CMake imported target + fix windows build + modernize Feb 3, 2022
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

All green in build 3 (56311a670c03b838aba4f1816c3d0dabd8f3e6b3):

  • libtins/4.2@:
    All packages built successfully! (All logs)

  • libtins/4.3@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit f98b611 into conan-io:master Feb 16, 2022
@SpaceIm SpaceIm deleted the libtins-modernize branch February 16, 2022 10:58
SSE4 pushed a commit to madebr/conan-center-index that referenced this pull request Feb 21, 2022
@SpaceIm @SSE4
(conan-io#9239) libtins: fix CMake imported target + fix windows buil…
e5aef69 
…d + modernize

* modernize & fix CMake imported target

* bump dependencies

* relocatable shared lib on macOS

* fix windows build

* explicit cpp_info.libs

* remove CMake folder during packaging on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@uilianries uilianries uilianries approved these changes

@jgsogo jgsogo jgsogo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SpaceIm @conan-center-bot @jgsogo @uilianries @prince-chrismc