mingw should require m4 #9172
Merged
mingw should require m4 #9172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
ericLemanissier
previously approved these changes
Jan 31, 2022
SSE4
previously approved these changes
Jan 31, 2022
prince-chrismc
previously approved these changes
Feb 2, 2022
7c02a19
|
All green in build 2 (
|
|
Added a fix to #9229 |
ericLemanissier
approved these changes
Feb 3, 2022
prince-chrismc
approved these changes
Feb 7, 2022
| @@ -307,10 +311,4 @@ def package_info(self): | |||
| self.env_info.STRIP = prefix + "strip" | |||
| self.env_info.GCOV = prefix + "gcov" | |||
| self.env_info.RC = prefix + "windres" | |||
| # Symlinks cannot be created in package step, otherwise the link target is wrong. | |||
There was a problem hiding this comment.
Wait the old comment said this was not possible 🤔
There was a problem hiding this comment.
It was not possible because the links were absolute.
To your question above, it does work consuming from an Artifactory server.
Comment on lines
+270
to
+273
| self.run("ln -s {} {}".format(os.path.join(os.curdir, self._target_tag), | ||
| os.path.join(self.package_folder, 'mingw'))) | ||
| self.run("ln -s {} {}".format(os.path.join(os.curdir, 'lib'), | ||
| os.path.join(self.package_folder, self._target_tag, 'lib64'))) |
There was a problem hiding this comment.
why not using tools.fix_symlinks() ?
There was a problem hiding this comment.
just in case, calling os.symlink should be more portable than ln -s command line.
There was a problem hiding this comment.
tools.fix_symlinks() doesn't work:
ERROR: The file is a broken symlink, verify that you are packaging the needed destination files: '/home/conan/.conan/data/mingw-w64/8.0.2/_/_/package/4cfe33ba23f3b0106f09220780349c6834f3da6e/lib/libcc1.so.0'.You can skip this check adjusting the 'general.skip_broken_symlinks_check' at the conan.conf file.
the link is generated relative to the package folder and not the link itself:
ls -l /home/conan/.conan/data/mingw-w64/8.0.2/_/_/package/4cfe33ba23f3b0106f09220780349c6834f3da6e/lib/libcc1.so.0
lrwxrwxrwx 1 conan 1001 19 Feb 7 08:24 /home/conan/.conan/data/mingw-w64/8.0.2/_/_/package/4cfe33ba23f3b0106f09220780349c6834f3da6e/lib/libcc1.so.0 -> lib/libcc1.so.0.0.0
SSE4
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: mingw-w64/8.0.2
closes #9170
conan-center hook activated.