octomap: relocatable shared libs on macOS #9143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All green in build 1 ( |
SSE4
reviewed
Jan 30, 2022
| @@ -82,6 +85,9 @@ def _patch_sources(self): | |||
| # No -Werror | |||
| if tools.Version(self.version) >= "1.9.6": | |||
| tools.replace_in_file(compiler_settings, "-Werror", "") | |||
| # we want a clean rpath in installed shared libs | |||
| tools.replace_in_file(compiler_settings, "set(CMAKE_INSTALL_RPATH \"${CMAKE_INSTALL_PREFIX}/lib\")", "") | |||
| tools.replace_in_file(compiler_settings, "set(CMAKE_INSTALL_RPATH_USE_LINK_PATH TRUE)", "") | |||
There was a problem hiding this comment.
in conan-io/hooks#376, you don't mention anything about CMAKE_INSTALL_RPATH/CMAKE_INSTALL_RPATH_UE_LINK_PATH. I think it should be explained why they have to be modified.
There was a problem hiding this comment.
Yes. Actually these 2 ones have to be left to their default value in CMake, otherwise it leads to hardcoded paths in RPATH of binaries in install tree.
SSE4
approved these changes
Jan 31, 2022
intelligide
approved these changes
Feb 3, 2022
prince-chrismc
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see conan-io/hooks#376
conan-center hook activated.