wineditline: address post-merge review comments #8867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
SpaceIm
reviewed
Jan 30, 2022
Comment on lines
30
to
33
| + | ||
| +include("${CMAKE_BINARY_DIR}/conanbuildinfo.cmake") | ||
| +conan_basic_setup(TARGETS) | ||
| + |
There was a problem hiding this comment.
I would isolate this part in the usual CMakeLists wrapper.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
All green in build 4 (
|
SpaceIm
approved these changes
Jan 31, 2022
prince-chrismc
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: wineditline/2.206
This PR addresses post-merge review comments: #8553 (comment)
conan-center hook activated.