Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iir1 bump cci #8835

Merged
merged 12 commits into from
Mar 7, 2022
Merged

Iir1 bump cci #8835

merged 12 commits into from
Mar 7, 2022

Conversation

wouterz
Copy link
Contributor

@wouterz wouterz commented Jan 11, 2022

Specify library name and version: iir1

bumping with a cci version as I have no indication when a new version is to be released.


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@ghost
Copy link

ghost commented Jan 11, 2022

I detected other pull requests that are modifying iir1/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@wouterz
Copy link
Contributor Author

wouterz commented Jan 12, 2022

A local build with the same profile seems to succeed, not sure where this is coming from

...
[HOOK - conan-center.py] post_package(): [MS RUNTIME FILES (KB-H021)] OK
iir1/cci.20211227 package(): Packaged 1 '.dll' file: iir.dll
iir1/cci.20211227 package(): Packaged 14 '.h' files
iir1/cci.20211227 package(): Packaged 1 '.lib' file: iir.lib
iir1/cci.20211227 package(): Packaged 1 file: COPYING
iir1/cci.20211227: Package 'd32867aa59c021b5efc1f4fb5b88d63569607fe1' created
...

Possibly the INSTALL RUNTIME that was added to the static lib?

Copy link
Contributor

@ericLemanissier ericLemanissier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be the cause of the failure

recipes/iir1/all/conandata.yml Outdated Show resolved Hide resolved
wouterz and others added 2 commits January 12, 2022 09:49
Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

recipes/iir1/all/conanfile.py Outdated Show resolved Hide resolved
SSE4
SSE4 previously approved these changes Jan 13, 2022
Spelling

Co-authored-by: SSE4 <tomskside@gmail.com>
@wouterz wouterz dismissed stale reviews from ericLemanissier and SSE4 via 558bafc January 13, 2022 19:22
@wouterz
Copy link
Contributor Author

wouterz commented Jan 13, 2022

I got away with comparing strings, but I wondered if there is a way to check the chronological order of versions, to check before or after specific versions? Parsing into major.minor.patch would work for normal versions but not custom release naming.

@conan-center-bot

This comment has been minimized.

@wouterz
Copy link
Contributor Author

wouterz commented Jan 14, 2022

Any logs on the unexpected failure? @ericLemanissier @SSE4

@prince-chrismc
Copy link
Contributor

Please do not force push 🙏 GitHub forces us to restart the review which is not fun!

@wouterz
Copy link
Contributor Author

wouterz commented Jan 21, 2022

Please do not force push 🙏 GitHub forces us to restart the review which is not fun!

Sorry, I pushed with wrong git config and required a new CLA, so I decided to remove that commit and redo it

@prince-chrismc
Copy link
Contributor

Oh then you had no choice, that's absolutely alright :)

recipes/iir1/all/conanfile.py Outdated Show resolved Hide resolved
recipes/iir1/all/conanfile.py Outdated Show resolved Hide resolved
recipes/iir1/all/conanfile.py Outdated Show resolved Hide resolved
SSE4
SSE4 previously approved these changes Feb 2, 2022
@ericLemanissier
Copy link
Contributor

1.9.1 is now out

recipes/iir1/all/conandata.yml Outdated Show resolved Hide resolved
@stale
Copy link

stale bot commented Mar 5, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 5, 2022
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@wouterz wouterz dismissed stale reviews from SSE4 and prince-chrismc via 8cb9673 March 6, 2022 20:50
@stale stale bot removed stale labels Mar 6, 2022
wouterz and others added 3 commits March 6, 2022 21:51
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>
Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@conan-center-bot
Copy link
Collaborator

All green in build 13 (7c940b5cbd3343ad401a0f3d4d03c564e6ebf1b4):

  • iir1/1.9.0@:
    All packages built successfully! (All logs)

  • iir1/1.9.1@:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit eb7ec70 into conan-io:master Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants