-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 'libprotobuf-mutator' recipe #8578
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, nice project, I didn't know about.
Please, take a look on my review. Happy new year!
"""# (disabled by conan) add_subdirectory(examples EXCLUDE_FROM_ALL)""") | ||
|
||
def validate(self): | ||
if self.settings.compiler != "clang": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a reference about it? I only found:
Clang is only needed for libFuzzer integration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
up!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still didn't answer!
This comment has been minimized.
This comment has been minimized.
@uilianries can't answer in the topic without reason. I don't know any compiler which support libfuzzer. |
You are saying this recipe could work with other compilers but you did not test? If yes, remove that privation. Let's run Linux and Windows build. We skip some setting when we have some information from the upstream, or the project doesn't work and the upstream doesn't know and a hotfix is costly. |
No. I mean that |
let's move forward. it's not strictly necessary to add all the possible configurations at the very first iteration. I think we're totally fine if someone wants to contribute some recipe, and doesn't want to test e.g. Windows, so puts |
Co-authored-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
All green in build 1 (
|
Specify library name and version: libprotobuf-mutator
https://www.youtube.com/watch?v=U60hC16HEDY
conan-center hook activated.