Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-sdk-cpp use openssl #8554

Merged
merged 2 commits into from
Jan 6, 2022
Merged

Conversation

MartinDelille
Copy link
Contributor

@MartinDelille MartinDelille commented Dec 27, 2021

Specify library name and version: aws-sdk-cpp/...

The purpose of this pull request is to make the SDK compliant with the Apple Store which reject private API usage on MacOS and iOS.

Switching to openssl fix the issue. This change seems reasonable since openssl is already in the recipe requirements.


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@ghost
Copy link

ghost commented Dec 27, 2021

I detected other pull requests that are modifying aws-sdk-cpp/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@MartinDelille
Copy link
Contributor Author

@jgsogo Any idea why this recipe doesn't build?

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@MartinDelille
Copy link
Contributor Author

I updated the description.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot

This comment has been minimized.

@MartinDelille
Copy link
Contributor Author

I closed and reopened the PR in order to try to remove the Unexpected Error tag but the CI behavior is very erratic.

@uilianries uilianries closed this Jan 6, 2022
@uilianries uilianries reopened this Jan 6, 2022
@conan-center-bot
Copy link
Collaborator

All green in build 6 (c8e7f98cd38a6ebee346ce09366089557d66e018):

  • aws-sdk-cpp/1.9.100@:
    All packages built successfully! (All logs)

  • aws-sdk-cpp/1.8.130@:
    All packages built successfully! (All logs)

@uilianries
Copy link
Member

All good now

@conan-center-bot conan-center-bot merged commit 62041ef into conan-io:master Jan 6, 2022
@MartinDelille MartinDelille deleted the awsopenssl branch January 7, 2022 18:48
miklelappo pushed a commit to miklelappo/conan-center-index that referenced this pull request Feb 9, 2022
* aws-sdk-cpp use openssl

* Always use aws-c-common/0.6.15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants