Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test other generators: run several tests in test_*/conanfile.py #8389
Test other generators: run several tests in test_*/conanfile.py #8389
Changes from all commits
f3e8908
03a4c3b
7c1da8d
9ac268a
6367b7a
90fe826
952941c
a883211
29ce22c
e6d6794
6281ae1
a27e7ee
31b9e5a
251189c
78eff63
0a3d449
e218ce7
bd5b5c1
20100d5
8a776c2
33dc9fc
7d887a4
5aa4c58
18da51d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is it needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed because the same
CMakeLists.txt
file is used from thetest_cmakedeps/conanfile.py
and there we are not adding thecmake
generator.IMO, it is important to reuse as much as possible the same project files.