Feature/add ofeli #8375
Feature/add ofeli #8375
Conversation
|
|
This comment has been minimized.
This comment has been minimized.
|
This PR solves #8333 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This PR resolve #8333 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@madebr the test fails for |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
All green in build 11 (
|
| topics = ("ofeli", "finite element", "finite element library", | ||
| "finite element analysis", "finite element solver") |
There was a problem hiding this comment.
| topics = ("ofeli", "finite element", "finite element library", | |
| "finite element analysis", "finite element solver") | |
| topics = ("finite-element", "finite-element-library", | |
| "finite-element-analysis", "finite-element-solver") |
Search engine interprets space as different topics.
| "Ofeli is just supported for GCC") | ||
| if self.settings.compiler.cppstd: | ||
| tools.check_min_cppstd(self, 11) | ||
| if self.settings.compiler.libcxx != "libstdc++11": |
There was a problem hiding this comment.
Which scenario it doesn't work? I'm able to with gcc and libstdc++ without any error.
There was a problem hiding this comment.
cf #8375 (comment)
The failure is the one happening in https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/8375/8-configs/linux-gcc/ofeli/4.1.2//summary.json for example
This is expected, because the upstream project ovewrites CPPFLAGS passed by conan, so it does not respect the profile regarding the cpp standard used, or libstdc++'s abi, so it ends up using the deafult, which is libstdc++11
| self.cpp_info.names["cmake_find_package"] = "Ofeli" | ||
| self.cpp_info.names["cmake_find_package_multi"] = "Ofeli" |
There was a problem hiding this comment.
Good catch. Master branch offers cmake support, but still is all lowercase.
* add ofeli library * follow pep8 * follow conan hooks * set compiler to c++11 * add c++ 11 standard to test_package * set supported compiler * check os for setting compiler * remove stdc++11 from conanfiles * check min cppstd and add debug or release build type choose * test with config_options * remote stdc++11 cppstd_flag and update license * check libstdc++ ABI support
Specify library name and version: ofeli/4.1.2
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!
conan-center hook activated.