Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mingw: split windows and linux recipes #8307

Closed
wants to merge 4 commits into from

Conversation

ericLemanissier
Copy link
Contributor

@ericLemanissier ericLemanissier commented Dec 2, 2021

Specify library name and version: mingw-w64/*

there is no change at all in the recipe, just a separation of the 2 paths (linux and windows), which are 99% of the time different.

related to #8306


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

toge
toge previously approved these changes Dec 3, 2021
AndreyMlashkin
AndreyMlashkin previously approved these changes Dec 3, 2021
madebr
madebr previously approved these changes Dec 3, 2021
@ericLemanissier
Copy link
Contributor Author

Context: this recipe is more or less "dead" because there is no plan to put newer version on http://sourceforge.net/projects/mingw-w64/. I will make a new windows recipe based on https://github.com/niXman/mingw-builds when a new tag will be made (niXman/mingw-builds#575)

@SSE4
Copy link
Contributor

SSE4 commented Dec 7, 2021

Context: this recipe is more or less "dead" because there is no plan to put newer version on http://sourceforge.net/projects/mingw-w64/. I will make a new windows recipe based on https://github.com/niXman/mingw-builds when a new tag will be made (niXman/mingw-builds#575)

this is kinda unfortunate. are these niXman binaries considered official? are they drop-in replacements for mingw-w64?

@ericLemanissier
Copy link
Contributor Author

AFAIK, there are no "official" migw-w64 binaries. But NiXman was already one of the contributors behind the mingw-builds binaries this recipe downloads from sourceforge

@SSE4
Copy link
Contributor

SSE4 commented Dec 7, 2021

AFAIK, there are no "official" migw-w64 binaries. But NiXman was already one of the contributors behind the mingw-builds binaries this recipe downloads from sourceforge

at this point, I am not completely sure if it should be just mingw or nixman-mingw to distinguish distribution.
if it's the main source of truth, it's okay to name it just mingw to avoid unnecessary confusion for consumers.
but there are other distributions, like https://nuwen.net/mingw.html or one provided with MSYS. are they considered equal?

@ericLemanissier
Copy link
Contributor Author

ericLemanissier commented Dec 7, 2021

Just to confirm what I said above, there is a file named build-info.txt in existing mingw-w64\8.1\_\_\package\*** and the file says user : nixman.
You are right that the situation needs to be improved regarding the multiple versions of mingw. I don't know if one is better than the other, but there are (at least) all the following:

EDIT: see #8349 The old sourceforge artifacts are consumable exactly the same way as new github artifacts, so the recipe is the same for both. When #8349 we should deprecate mingw-w64/8.1 and recommend migrating to mingw-builds/*

@conan-center-bot
Copy link
Collaborator

All green in build 2 (7664bf05c30d4663b1f405b92f8d248c8fa8ad41):

  • mingw-w64/8.1@:
    All packages built successfully! (All logs)

@ericLemanissier ericLemanissier mentioned this pull request Jan 12, 2022
4 tasks
@conan-center-bot conan-center-bot requested a review from SSE4 January 21, 2022 12:01
@ericLemanissier
Copy link
Contributor Author

closing this one in favor of #8349

@ericLemanissier ericLemanissier deleted the mingw-windows branch February 2, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants