Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android-ndk: set CONAN_CMAKE_SYSTEM_PROCESSOR #7474

Merged

Conversation

madebr
Copy link
Contributor

@madebr madebr commented Oct 1, 2021

Specify library name and version: lib/1.0

When cross building to armv8 android, we need to set CMAKE_SYSTEM_PROCESSOR=aarch64 explicitly.

These are the available values

Without this pr, this error is shown

(This is where I encountered it)

Also,

  • I've reformatted the recipe to use double quotes + f-strings
  • encoded the valid os/arch in conandata.yml. If the recipe cannot find sources in the conandata.yml, then it's not supported
  • Also moved the download from source to build. android-ndk is a package of a binary artifact, and is different for each os/arch.

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@madebr madebr force-pushed the android-ndk-CMAKE_SYSTEM_PROCESSOR branch from cf57c4e to dc07502 Compare October 1, 2021 01:00
@conan-center-bot
Copy link
Collaborator

All green in build 4 (8906cccf6951d242ecb4099f6a6696ff12f22de9):

  • android-ndk/r23@:
    All packages built successfully! (All logs)

  • android-ndk/r22b@:
    All packages built successfully! (All logs)

  • android-ndk/r22@:
    All packages built successfully! (All logs)

  • android-ndk/r21e@:
    All packages built successfully! (All logs)

  • android-ndk/r21d@:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 009e863 into conan-io:master Oct 2, 2021
@madebr madebr deleted the android-ndk-CMAKE_SYSTEM_PROCESSOR branch October 2, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants