-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OpenCV] Make the protobuf version a property #7437
[OpenCV] Make the protobuf version a property #7437
Conversation
…and the build_requirement are in sync
I detected other pull requests that are modifying opencv/4.x recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough, as github diff hides untouched code, any dependencies bump could result in your case.
It is hard to tell if this is making progress or if it is stuck. |
30hrs for OpenCV might be sensible... Maybe the team can look internal at Jenkins tomorrow? 🙏 |
This comment has been minimized.
This comment has been minimized.
Triggering that build again, sometimes it happens that the CI hangs 🤷 About the PR, I would also add one extra check. Conan can override the def build(self):
if self.deps_cpp_info["protobuf"].version != self. _protobuf_version:
raise ConanInvalidConfiguration("You are linking with protobuf/{} while your build require is protobuf/{}. Both need to be the same") Typically this should go in |
All green in build 2 ( |
I'm using a custom version of protobuf. I spent a bunch of time trying to debug a build error, turns out my protobuf versions were not in sync.
I can see this happening again when someone updates the version here. Current implementation is error prone.
By making the version a property we ensure that both the requirement and the build_requierement are in sync.
conan-center hook activated.