-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add capnproto/0.9.1 #7429
Add capnproto/0.9.1 #7429
Conversation
This comment has been minimized.
This comment has been minimized.
0fab85a
to
4bac3a7
Compare
This comment has been minimized.
This comment has been minimized.
Building the tests on macOS/M1 with The build fails while calling the
Note the subtle difference Interestingly, this is a problem with the
Edit: Best I could come up with is change of |
bd29b84
to
50bf8a2
Compare
This comment has been minimized.
This comment has been minimized.
50bf8a2
to
010cee9
Compare
This comment has been minimized.
This comment has been minimized.
if self.settings.os == "Macos" and self.settings.arch == "armv8": | ||
# Attempting to use @rpath without CMAKE_SHARED_LIBRARY_RUNTIME_C_FLAG being | ||
# set. This could be because you are using a Mac OS X version less than 10.5 | ||
# or because CMake's platform configuration is corrupt. | ||
self.build_requires("cmake/3.20.1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be moved to the main recipe as the fix for the RPATH problems?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found this fix in the test packages for boost
and gsl
.
The main recipe builds with autotools on Linux/macOS and doesn't require CMake. It seems like the recent version of CMake is just needed on macOS/M1 to build any package depending on libraries with @rpath
.
How would it be possible to inject a build_requires
on the depending package? Is build_requires
from the main package propagated down?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it's cmake bug, and we didn't upgrade cmake on mac slaves (and cannot at the moment, unfortunately)
the workaround should be in test package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, add #FIXME
to you comment so we can filter it in the future when looking for technical debt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the #FIXME
comment.
Please do not force push 🙏 GitHub forces us to restart the review which is not fun! |
It's worth noting that this is a partial fix. If openssl or zlib are shared, it breaks because they are not located in |
Specify library name and version: capnproto/0.9.1
Adds version 0.9.1, which contains numerous bugfixes and includes most patches that were previously applied for the build of this recipe.
The only remaining patch is to disable tests for the
autotools
build. Not sure whether this is still needed. Possibly to avoid issues when cross-compiling?conan-center hook activated.