Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[corrade] Build using emsdk #7410

Merged
merged 1 commit into from
Sep 28, 2021
Merged

[corrade] Build using emsdk #7410

merged 1 commit into from
Sep 28, 2021

Conversation

jgsogo
Copy link
Contributor

@jgsogo jgsogo commented Sep 25, 2021

Prepare library to build with Emscripten 💪

It works using emsdk package from this PR (#6163) plus changes proposed here (https://github.com/werto87/conan-center-index/pull/2).

conan create corrade/all/conanfile.py corrade/2020.06@ --profile:host=emsdk --profile:build=default

profile:host

[settings]
os=Emscripten
arch=wasm
compiler=clang
compiler.version=14
build_type=Release
[options]
[conf]
[build_requires]
*: emsdk/2.0.30
[env]

@prince-chrismc prince-chrismc mentioned this pull request Sep 25, 2021
Open
@conan-center-bot
Copy link
Collaborator

All green in build 1 (b6aa48beb07ddc28fa0dc04279a0133652ad084c):

  • corrade/2020.06@:
    All packages built successfully! (All logs)

  • corrade/2019.10@:
    All packages built successfully! (All logs)

This was referenced Sep 25, 2021
Closed
Closed
@SSE4 SSE4 requested a review from uilianries September 26, 2021 06:11
@jgsogo jgsogo mentioned this pull request Sep 27, 2021
Open
1 task
uilianries
uilianries reviewed Sep 27, 2021
View reviewed changes
recipes/corrade/all/test_package/conanfile.py

if self.settings.os == "Emscripten":
bin_path = os.path.join("bin", "test_package.js")
self.run("node {}".format(bin_path), run_environment=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need https://conan.io/center/nodejs here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is already a requirement when using Emscripten.

@conan-center-bot conan-center-bot merged commit a2bb060 into conan-io:master Sep 28, 2021
@jgsogo jgsogo deleted the emsdk-corrade branch September 28, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@intelligide intelligide intelligide approved these changes

@uilianries uilianries uilianries approved these changes

@SSE4 SSE4 SSE4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jgsogo @conan-center-bot @SSE4 @uilianries @intelligide