Adds rapidcheck gtest/catch integrations

[mjvankampen]

Specify library name and version: rapidcheck

Rapidcheck provides integration with multiple unit test frameworks. This enables those integrations within the conan package

---

• I've read the guidelines for contributing.
• I've followed the PEP8 style guides for Python code in the recipes.
• I've used the latest Conan client version.
• I've tried at least one configuration locally with the
  conan-center hook activated.

[mjvankampen]

Excuse the mess, not my finest moment

[prince-chrismc]

The component names do not match the official ones 😕

https://github.com/emil-e/rapidcheck/search?q=rapidcheckConfig

• core --> rapidcheck
• the frameworks should be prefixed with rapidcheck_

---

Also why are there no require statements? I would expect "enable_catch" to include catch..
https://github.com/emil-e/rapidcheck/blob/fc616114a95a3198514f8b4ec9e354865fd6ecfc/extras/catch/include/rapidcheck/catch.h#L6

Would fail to compile without it

[prince-chrismc]

Could this be one option?

Suggested change

	"enable_catch": [True, False],
	"enable_gmock": [True, False],
	"enable_gtest": [True, False],
	"enable_boost": [True, False],
	"enable_boost_test": [True, False]
	"enable_framework": [False, "catch", "gmock", "gtest", "boost", "boost_test"],

[mjvankampen]

No I don't think so as you can enable multiple integrations at the same time.

[mjvankampen]

Requires: I see, catch and gmock are handled differently from the rest. F.e. gtest requires the consumer to link gtest, include gtest header and then include rapidcheck header which makes sense to not require gtest. Different for catch. Will check it out.

Names: I think the official targets are not namespaced correct? This is why the aliases with the correct names are added without a namespace.

Core is just the name of the component, it cannot be the same name as the package I think. The resulting target is still named rapidcheck::rapidcheck (and aliased to rapidcheck)

[mjvankampen]

Please have a look. I left out boost for now. I think it is not very nice to link gtest/catch to the core lib, but I would like to keep the gtest and such integration libs INTERFACE libraries to not change the code around too much.

[prince-chrismc]

I think it is not very nice to link gtest/catch to the core lib, but I would like to keep the gtest and such integration libs INTERFACE libraries to not change the code around too much.

I absolutely agree, its completely customer facing.
You should have added it to the framework components not to "core"

I am not sure why you added patches since that was not required in the first place 🤔

The CMake aliases are perfect, my previous note was about the Conan ones... when you go to use them in a downstream conanfile the sames are not very distinctive (they are the names of other projects) without the prefix that upstream uses

[mjvankampen]

Please have a look if this addresses your concerns:

1. I added the external libs to core as they are introduced to into the upstream project as cmake subdirectory. I don't think we can do anything similar on conan so I thought this was closest. I agree it is not.
2. A patch is required to disable the git submodules. Agreed that the rest of the patch is not required.
3. Clear updated

[prince-chrismc]

Amazing work!

[uilianries]

@prince-chrismc Good catch! thanks for reviewing!

[conan-center-bot]

All green in build 13 (c55c7509e20d2dbb845ab940430e86c12215d751):

• rapidcheck/cci.20200131@:
  All packages built successfully! (All logs)

• rapidcheck/cci.20210702@:
  All packages built successfully! (All logs)

• rapidcheck/cci.20210107@:
  All packages built successfully! (All logs)

[uilianries]

LGTM