Added 2.1 liburing version #7266

TheSalvator · 2021-09-12T13:45:33Z

liburing/0.1
liburing/0.2
liburing/0.3
liburing/0.4
liburing/0.5
liburing/0.6
liburing/2.1

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

TheSalvator · 2021-09-12T14:07:38Z

Failure in build 1 (568d0c645cc90b4f0c8bbbff06552c033fe9c24d):

* **liburing/2.0@:**
  All packages built successfully! ([All logs](https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/7266/1/summary.json))

* **liburing/2.1@:**
  CI failed to create some packages ([All logs](https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/7266/1-configs/linux-gcc/liburing/2.1//summary.json))
  Logs for packageID `58f9a71fb63a0cde3fe61d7a8fb64e8233b0d823`:
  ```
  [settings]
  arch=x86_64
  arch_build=x86_64
  build_type=Release
  compiler=gcc
  compiler.libcxx=libstdc++11
  compiler.version=5
  os=Linux
  os_build=Linux
  [options]
  liburing:shared=False
  ```
  
  
      
        
      
  
        
      
  
      
    
  ```
  [...]
   # define MAP_LOCKED 0x02000  /* Lock the mapping.  */
   ^
  In file included from /home/conan/w/BuildSingleReference/.conan/data/linux-headers-generic/5.13.9/_/_/package/c0519e2d9702ec12d057bb15adb7a02baaf18107/include/asm/mman.h:29:0,
                   from /home/conan/w/BuildSingleReference/.conan/data/linux-headers-generic/5.13.9/_/_/package/c0519e2d9702ec12d057bb15adb7a02baaf18107/include/linux/mman.h:5,
                   from io_uring_register.c:21:
  /home/conan/w/BuildSingleReference/.conan/data/linux-headers-generic/5.13.9/_/_/package/c0519e2d9702ec12d057bb15adb7a02baaf18107/include/asm-generic/mman.h:11:0: warning: "MAP_NORESERVE" redefined
   #define MAP_NORESERVE 0x4000  /* don't check for reservations */
   ^
  In file included from /usr/include/x86_64-linux-gnu/sys/mman.h:41:0,
                   from io_uring_register.c:20:
  /usr/include/x86_64-linux-gnu/bits/mman.h:37:0: note: this is the location of the previous definition
   # define MAP_NORESERVE 0x04000  /* Don't check for reservations.  */
   ^
  In file included from io_uring_register.c:21:0:
  /home/conan/w/BuildSingleReference/.conan/data/linux-headers-generic/5.13.9/_/_/package/c0519e2d9702ec12d057bb15adb7a02baaf18107/include/linux/mman.h:27:0: warning: "MAP_HUGE_SHIFT" redefined
   #define MAP_HUGE_SHIFT HUGETLB_FLAG_ENCODE_SHIFT
   ^
  In file included from /usr/include/x86_64-linux-gnu/bits/mman.h:45:0,
                   from /usr/include/x86_64-linux-gnu/sys/mman.h:41,
                   from io_uring_register.c:20:
  /usr/include/x86_64-linux-gnu/bits/mman-linux.h:62:0: note: this is the location of the previous definition
   # define MAP_HUGE_SHIFT 26
   ^
  In file included from io_uring_register.c:21:0:
  /home/conan/w/BuildSingleReference/.conan/data/linux-headers-generic/5.13.9/_/_/package/c0519e2d9702ec12d057bb15adb7a02baaf18107/include/linux/mman.h:28:0: warning: "MAP_HUGE_MASK" redefined
   #define MAP_HUGE_MASK HUGETLB_FLAG_ENCODE_MASK
   ^
  In file included from /usr/include/x86_64-linux-gnu/bits/mman.h:45:0,
                   from /usr/include/x86_64-linux-gnu/sys/mman.h:41,
                   from io_uring_register.c:20:
  /usr/include/x86_64-linux-gnu/bits/mman-linux.h:63:0: note: this is the location of the previous definition
   # define MAP_HUGE_MASK 0x3f
   ^
  io_uring_register.c: In function ‘test_shmem’:
  io_uring_register.c:514:10: warning: implicit declaration of function ‘memfd_create’ [-Wimplicit-function-declaration]
    memfd = memfd_create("uring-shmem-test", 0);
            ^
  /tmp/ccrXJ3mj.o: In function `main':
  io_uring_register.c:(.text.startup+0x1e6): undefined reference to `memfd_create'
  collect2: error: ld returned 1 exit status
  make[1]: *** [io_uring_register] Error 1
  make[1]: *** Waiting for unfinished jobs....
  make: *** [all] Error 2
  linux-headers-generic/5.13.9: WARN: Lib folder doesn't exist, can't collect libraries: /home/conan/w/BuildSingleReference/.conan/data/linux-headers-generic/5.13.9/_/_/package/c0519e2d9702ec12d057bb15adb7a02baaf18107/lib
  liburing/2.1: WARN: Build folder is dirty, removing it: /home/conan/w/BuildSingleReference/.conan/data/liburing/2.1/_/_/build/58f9a71fb63a0cde3fe61d7a8fb64e8233b0d823
  liburing/2.1: ERROR: Package '58f9a71fb63a0cde3fe61d7a8fb64e8233b0d823' build failed
  liburing/2.1: WARN: Build folder /home/conan/w/BuildSingleReference/.conan/data/liburing/2.1/_/_/build/58f9a71fb63a0cde3fe61d7a8fb64e8233b0d823
  ERROR: liburing/2.1: Error in build() method, line 75
  	autotools.make()
  	ConanException: Error 2 while executing make -j3
  ```

* **liburing/0.6@:**
  All packages built successfully! ([All logs](https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/7266/1/summary.json))

* **liburing/0.7@:**
  All packages built successfully! ([All logs](https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/7266/1/summary.json))

* **liburing/0.5@:**
  All packages built successfully! ([All logs](https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/7266/1/summary.json))

* **liburing/0.2@:**
  All packages built successfully! ([All logs](https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/7266/1/summary.json))

* **liburing/0.1@:**
  All packages built successfully! ([All logs](https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/7266/1/summary.json))

* **liburing/0.4@:**
  All packages built successfully! ([All logs](https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/7266/1/summary.json))

* **liburing/0.3@:**
  All packages built successfully! ([All logs](https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/7266/1/summary.json))

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

conan-io/conan#7208
Please take a look at the attached files, I still think shipping linux headers as conan package is bad idea
2.1-source-build.log
2.1-conan-build.log

This reverts commit 4250b69.

TheSalvator · 2021-09-12T15:13:31Z

Failure in build 3 (f7d1fece1776cc83ba657ea1a6481afcf74a426a):

* **liburing/2.1@:**
  CI failed to create some packages ([All logs](https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/7266/3-configs/linux-gcc/liburing/2.1//summary.json))
  Logs for packageID `b1b85bfdc2206d81b3ed6a49e78498182bb98ef3`:
  ```
  [settings]
  arch=x86_64
  arch_build=x86_64
  build_type=Debug
  compiler=gcc
  compiler.libcxx=libstdc++11
  compiler.version=5
  os=Linux
  os_build=Linux
  [options]
  liburing:shared=False
  ```
  
  
      
        
      
  
        
      
  
      
    
  ```
  [...]
       CC cq-full
       CC cq-overflow
       CC cq-peek-batch
       CC cq-ready
       CC cq-size
       CC d4ae271dfaae-test
       CC d77a67ed5f27-test
       CC defer
       CC double-poll-crash
       CC eeed8b54e0df-test
       CC empty-eownerdead
       CC eventfd
       CC eventfd-disable
       CC eventfd-ring
       CC fadvise
       CC fallocate
       CC fc2a85cb02ef-test
       CC file-register
       CC file-update
       CC files-exit-hang-poll
       CC files-exit-hang-timeout
       CC fixed-link
       CC fsync
       CC hardlink
       CC io-cancel
       CC io_uring_enter
       CC io_uring_register
       CC io_uring_setup
       CC iopoll
  Makefile:162: recipe for target 'io_uring_register' failed
  make[1]: Leaving directory '/home/conan/w/BuildSingleReference/.conan/data/liburing/2.1/_/_/build/b1b85bfdc2206d81b3ed6a49e78498182bb98ef3/source_subfolder/test'
  Makefile:12: recipe for target 'all' failed
  liburing/2.1: 
  ar: creating liburing.a
  io_uring_register.c: In function ‘test_shmem’:
  io_uring_register.c:514:10: warning: implicit declaration of function ‘memfd_create’ [-Wimplicit-function-declaration]
    memfd = memfd_create("uring-shmem-test", 0);
            ^
  /tmp/ccg8I7b6.o: In function `test_shmem':
  /home/conan/w/BuildSingleReference/.conan/data/liburing/2.1/_/_/build/b1b85bfdc2206d81b3ed6a49e78498182bb98ef3/source_subfolder/test/io_uring_register.c:514: undefined reference to `memfd_create'
  collect2: error: ld returned 1 exit status
  make[1]: *** [io_uring_register] Error 1
  make[1]: *** Waiting for unfinished jobs....
  make: *** [all] Error 2
  liburing/2.1: WARN: Build folder is dirty, removing it: /home/conan/w/BuildSingleReference/.conan/data/liburing/2.1/_/_/build/b1b85bfdc2206d81b3ed6a49e78498182bb98ef3
  liburing/2.1: ERROR: Package 'b1b85bfdc2206d81b3ed6a49e78498182bb98ef3' build failed
  liburing/2.1: WARN: Build folder /home/conan/w/BuildSingleReference/.conan/data/liburing/2.1/_/_/build/b1b85bfdc2206d81b3ed6a49e78498182bb98ef3
  ERROR: liburing/2.1: Error in build() method, line 76
  	autotools.make()
  	ConanException: Error 2 while executing make -j3
  ```

* **liburing/2.0@:**
  All packages built successfully! ([All logs](https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/7266/3/summary.json))

* **liburing/0.7@:**
  All packages built successfully! ([All logs](https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/7266/3/summary.json))

* **liburing/0.5@:**
  CI failed to create some packages ([All logs](https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/7266/3-configs/linux-gcc/liburing/0.5//summary.json))
  Logs for packageID `b1b85bfdc2206d81b3ed6a49e78498182bb98ef3`:
  ```
  [settings]
  arch=x86_64
  arch_build=x86_64
  build_type=Debug
  compiler=gcc
  compiler.libcxx=libstdc++11
  compiler.version=5
  os=Linux
  os_build=Linux
  [options]
  liburing:shared=False
  ```
  
  
      
        
      
  
        
      
  
      
    
  ```
  [...]
       CC fc2a85cb02ef-test
       CC poll-link
       CC accept-link
       CC fixed-link
       CC poll-cancel-ton
       CC teardowns
       CC poll-many
       CC b5837bd5311d-test
       CC accept-test
       CC d77a67ed5f27-test
       CC connect
       CC 7ad0e4b2f83c-test
       CC submit-reuse
       CC fallocate
       CC open-close
       CC file-update
       CC statx
       CC accept-reuse
       CC poll-v-poll
  Makefile:34: recipe for target 'statx' failed
  make[1]: Leaving directory '/home/conan/w/BuildSingleReference/.conan/data/liburing/0.5/_/_/build/b1b85bfdc2206d81b3ed6a49e78498182bb98ef3/source_subfolder/test'
  Makefile:12: recipe for target 'all' failed
  liburing/0.5: 
  ar: creating liburing.a
  statx.c: In function ‘test_statx’:
  statx.c:49:15: error: storage size of ‘x1’ isn’t known
    struct statx x1;
                 ^
  statx.c:51:15: error: storage size of ‘x2’ isn’t known
    struct statx x2;
                 ^
  statx.c:60:40: error: ‘STATX_ALL’ undeclared (first use in this function)
    io_uring_prep_statx(sqe, -1, path, 0, STATX_ALL, &x1);
                                          ^
  statx.c:60:40: note: each undeclared identifier is reported only once for each function it appears in
  statx.c:51:15: warning: unused variable ‘x2’ [-Wunused-variable]
    struct statx x2;
                 ^
  statx.c:49:15: warning: unused variable ‘x1’ [-Wunused-variable]
    struct statx x1;
                 ^
  make[1]: *** [statx] Error 1
  make[1]: *** Waiting for unfinished jobs....
  make: *** [all] Error 2
  liburing/0.5: WARN: Build folder is dirty, removing it: /home/conan/w/BuildSingleReference/.conan/data/liburing/0.5/_/_/build/b1b85bfdc2206d81b3ed6a49e78498182bb98ef3
  liburing/0.5: ERROR: Package 'b1b85bfdc2206d81b3ed6a49e78498182bb98ef3' build failed
  liburing/0.5: WARN: Build folder /home/conan/w/BuildSingleReference/.conan/data/liburing/0.5/_/_/build/b1b85bfdc2206d81b3ed6a49e78498182bb98ef3
  ERROR: liburing/0.5: Error in build() method, line 76
  	autotools.make()
  	ConanException: Error 2 while executing make -j3
  ```

* **liburing/0.6@:**
  All packages built successfully! ([All logs](https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/7266/3/summary.json))

* **liburing/0.3@:**
  All packages built successfully! ([All logs](https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/7266/3/summary.json))

* **liburing/0.4@:**
  All packages built successfully! ([All logs](https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/7266/3/summary.json))

* **liburing/0.2@:**
  All packages built successfully! ([All logs](https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/7266/3/summary.json))

* **liburing/0.1@:**
  All packages built successfully! ([All logs](https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/7266/3/summary.json))

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

About 2.1 build fail:
memfd_create call requires glibc >= 2.27. This means that library should be built on host who has one, I don't know how to check it's version without using platform module

Due to restriction of using platform python module in configure and validate methods. It is impossible for now to build this version on hosts with glibc 2.26 and less

TheSalvator · 2021-09-12T20:42:44Z

All green in build 8 (36a1a210cd6534720cc6395752497e82b9b61924):

* **liburing/0.7@:**
  All packages built successfully! ([All logs](https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/7266/8/summary.json))

* **liburing/2.0@:**
  All packages built successfully! ([All logs](https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/7266/8/summary.json))

* **liburing/0.6@:**
  All packages built successfully! ([All logs](https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/7266/8/summary.json))

* **liburing/0.3@:**
  All packages built successfully! ([All logs](https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/7266/8/summary.json))

* **liburing/0.5@:**
  All packages built successfully! ([All logs](https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/7266/8/summary.json))

* **liburing/0.4@:**
  All packages built successfully! ([All logs](https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/7266/8/summary.json))

* **liburing/0.2@:**
  All packages built successfully! ([All logs](https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/7266/8/summary.json))

* **liburing/0.1@:**
  All packages built successfully! ([All logs](https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/7266/8/summary.json))

Did you know that it is not this easy to find gcc5 nowadays?

uilianries · 2021-09-13T20:39:11Z

Hello @TheSalvator do you really need all those versions? We try avoiding old project versions to save some CI resource, and also to keep the maintenance cleaner (less versions, less code).

TheSalvator · 2021-09-14T18:58:56Z

Hello @TheSalvator do you really need all those versions? We try avoiding old project versions to save some CI resource, and also to keep the maintenance cleaner (less versions, less code).

Sorry, I didn't know this, I'll comment out old version. Still there is a new version of liburing 2.1 and it cannot be built on hosts with glibc < 2.27. I think I need help to create some workaround since I cannot use platform module in configure

ghost · 2021-10-06T22:50:45Z

I detected other pull requests that are modifying liburing/all recipe:

Bugfix: fix frameworks usage with components (cmake_find_package_multi) conan#7580

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

jgsogo

There are also some minor comments from other reviewers.

recipes/liburing/all/patches/0001-liburing-2.1-memfd-create.patch

jgsogo · 2021-10-07T15:53:43Z

recipes/liburing/all/conanfile.py

-    def requirements(self):
-        self.requires("linux-headers-generic/5.13.9")
+    def build_requirements(self):
+        self.build_requires("linux-headers-generic/5.13.9")


Yes, please, what is the purpose here? Probably using one profile it doesn't make any difference, but is it needed (does it work) if using two profiles?

This reverts commit 574a182.

recipes/liburing/all/conanfile.py

Removed unused import Co-authored-by: Uilian Ries <uilianries@gmail.com>

conan-center-bot · 2021-10-11T21:17:30Z

All green in build 19 (a8ff55422e22343ba7face1f980bb28fad7ccee7):

liburing/2.0@:
All packages built successfully! (All logs)
liburing/2.1@:
All packages built successfully! (All logs)
liburing/0.7@:
All packages built successfully! (All logs)

TheSalvator · 2021-10-20T18:07:39Z

Hey guys, can you review changes one more time?

madebr · 2021-10-20T18:18:32Z

recipes/liburing/all/patches/0001-liburing-2.1-memfd-create.patch

+@@ -1,5 +1,5 @@
+ Name: liburing
+-Version: 2.0
+Version: 2.1


Nice, but not really needed for this recipe.

It doesn't affect anything, if you insist, I'll remove it

You can leave it. It was just a remark.

madebr · 2021-10-21T14:36:16Z

@jgsogo
I think you are blocking this pr.

* Added 0.1 0.2 0.3 0.4 0.5 0.6 and 2.1 liburing versions * Revert "(conan-io#7208) liburing: remove call to `platform` in validate" This reverts commit 4250b69. * Removed linux version check * Added statx fix patch to 0.5 version * Temporary disabled 2.1 Due to restriction of using platform python module in configure and validate methods. It is impossible for now to build this version on hosts with glibc 2.26 and less * Updated patch for liburing-0.5 * Added statx patches for 0.3 0.4 and 0.5 * Commented out old liburing versions * Revert "Temporary disabled 2.1" This reverts commit 6685ac1. * Disabled build for gcc5 and less * Added glibc version check through ldd * Removed old versions * Protected get_glibc_version method * Reverted test package from 568d0c6 * Improve glibc detection Signed-off-by: Uilian Ries <uilianries@gmail.com> * Update recipes/liburing/all/conanfile.py Co-authored-by: Ilya Kazakov <31013302+TheSalvator@users.noreply.github.com> * Added patch to deal with missing memfd_create * Removed glibc check * Revert "Revert "(conan-io#7208) liburing: remove call to `platform` in validate"" This reverts commit 260a8eb. * Moved linux headers package to build requires * (conan-io#7266) Updated patch file for liburing 2.1 * Revert "Moved linux headers package to build requires" This reverts commit 574a182. * Update recipes/liburing/all/conanfile.py Removed unused import Co-authored-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Uilian Ries <uilianries@gmail.com>

Added 0.1 0.2 0.3 0.4 0.5 0.6 and 2.1 liburing versions

568d0c6

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Sep 12, 2021

Revert "(#7208) liburing: remove call to platform in validate"

260a8eb

This reverts commit 4250b69.

This comment has been minimized.

Sign in to view

Removed linux version check

f7d1fec

This comment has been minimized.

Sign in to view

Added statx fix patch to 0.5 version

e8e1534

This comment has been minimized.

Sign in to view

conan-center-bot added Unexpected Error and removed Failed labels Sep 12, 2021

Temporary disabled 2.1

6685ac1

Due to restriction of using platform python module in configure and validate methods. It is impossible for now to build this version on hosts with glibc 2.26 and less

This comment has been minimized.

Sign in to view

conan-center-bot added Failed and removed Unexpected Error labels Sep 12, 2021

This was referenced Sep 12, 2021

Updatable recipes qchateau/conan-center-bot#1

Open

[request] Updatable recipes #3470

Closed

Updated patch for liburing-0.5

9c09379

This comment has been minimized.

Sign in to view

Added statx patches for 0.3 0.4 and 0.5

36a1a21

This comment has been minimized.

Sign in to view

conan-center-bot removed the Failed label Sep 12, 2021

prince-chrismc mentioned this pull request Sep 12, 2021

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

Commented out old liburing versions

38e7fcc

uilianries previously approved these changes Oct 6, 2021

View reviewed changes

This was referenced Oct 6, 2021

[service] Potentially conflicting recipes #3571

Closed

Bump liburing #7580

Closed

jgsogo suggested changes Oct 7, 2021

View reviewed changes

conan-center-bot requested a review from czoido October 8, 2021 11:57

(#7266) Updated patch file for liburing 2.1

c641ff8

TheSalvator dismissed stale reviews from uilianries and SSE4 via c641ff8 October 9, 2021 19:26

TheSalvator requested review from jgsogo, uilianries and SSE4 October 9, 2021 19:38

This comment has been minimized.

Sign in to view

Revert "Moved linux headers package to build requires"

7423c48

This reverts commit 574a182.

This comment has been minimized.

Sign in to view

SSE4 previously approved these changes Oct 11, 2021

View reviewed changes

uilianries reviewed Oct 11, 2021

View reviewed changes

recipes/liburing/all/conanfile.py Outdated Show resolved Hide resolved

Update recipes/liburing/all/conanfile.py

a8ff554

Removed unused import Co-authored-by: Uilian Ries <uilianries@gmail.com>

TheSalvator dismissed SSE4’s stale review via a8ff554 October 11, 2021 20:58

conan-center-bot requested a review from SSE4 October 12, 2021 12:00

SSE4 approved these changes Oct 12, 2021

View reviewed changes

danimtb approved these changes Oct 13, 2021

View reviewed changes

madebr approved these changes Oct 20, 2021

View reviewed changes

conan-center-bot requested a review from uilianries October 21, 2021 12:02

conan-center-bot requested a review from memsharded October 22, 2021 12:02

danimtb merged commit 6d5420f into conan-io:master Oct 27, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added 2.1 liburing version #7266

Added 2.1 liburing version #7266

TheSalvator commented Sep 12, 2021

This comment has been minimized.

TheSalvator commented Sep 12, 2021

This comment has been minimized.

This comment has been minimized.

TheSalvator commented Sep 12, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

TheSalvator commented Sep 12, 2021

uilianries commented Sep 13, 2021

TheSalvator commented Sep 14, 2021

ghost commented Oct 6, 2021

jgsogo left a comment

jgsogo Oct 7, 2021

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented Oct 11, 2021

TheSalvator commented Oct 20, 2021

madebr Oct 20, 2021

TheSalvator Oct 21, 2021

madebr Oct 21, 2021

madebr commented Oct 21, 2021

Added 2.1 liburing version #7266

Added 2.1 liburing version #7266

Conversation

TheSalvator commented Sep 12, 2021

This comment has been minimized.

TheSalvator commented Sep 12, 2021

This comment has been minimized.

This comment has been minimized.

TheSalvator commented Sep 12, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

TheSalvator commented Sep 12, 2021

uilianries commented Sep 13, 2021

TheSalvator commented Sep 14, 2021

ghost commented Oct 6, 2021

jgsogo left a comment

Choose a reason for hiding this comment

jgsogo Oct 7, 2021

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented Oct 11, 2021

TheSalvator commented Oct 20, 2021

madebr Oct 20, 2021

Choose a reason for hiding this comment

TheSalvator Oct 21, 2021

Choose a reason for hiding this comment

madebr Oct 21, 2021

Choose a reason for hiding this comment

madebr commented Oct 21, 2021