nspr: bump + modernize + no tools.os_info in `build_requirements` #7212

madebr · 2021-09-08T16:43:48Z

Specify library name and version: nspr/1.0

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

madebr · 2021-09-08T22:32:16Z

@timblechmann
When building nspr for Apple M1, the build script detects CPU_ARCH=ppc.
Since you committed #4770 (and own a Mac), can you take a look at the apple failure?

config.log is printed out in the build logs of https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/7212/2-configs/macos-m1-clang/nspr/4.27//summary.json
It shows CPU_ARCH='ppc'

(Also CC'ing @SpaceIm because he owns a Mac)

timblechmann · 2021-09-09T00:13:46Z

hi @madebr: unfortunately i don't have access to an m1 (i had only ssh-ed into one for a project last year.

that said: older nspr versions don't build on apple silicon: it is only supported since 4.29. but i guess you could try to backport the patches listed in https://bugzilla.mozilla.org/show_bug.cgi?id=1658671

prince-chrismc · 2021-09-16T01:47:15Z

recipes/nspr/all/conanfile.py

-        os.rename(extracted_dir, self._source_subfolder)
-        tools.rmdir(os.path.join("nspr-" + self.version))
+        tools.get(**self.conan_data["sources"][self.version],
+                  destination="tmp", strip_root=True)


Feature request? strip_root=2

It worth an issue

please fill a feature request to conan client

prince-chrismc · 2021-10-07T01:02:48Z

You'll need to retrigger CI, close the pr wait 10s and then re-open it 🔁

jgsogo · 2021-10-11T10:19:34Z

Something is wrong with this PR. The CI has been running for 4 days. No output so far. We need to check it carefully.

This reverts commit 3a9dd3e.

recipes/nspr/all/conanfile.py

… function (https://www-archive.mozilla.org/projects/nspr/reference/html/prinit.html#15758) Signed-off-by: SSE4 <tomskside@gmail.com>

Signed-off-by: SSE4 <tomskside@gmail.com>

This reverts commit 0a8b084.

Signed-off-by: SSE4 <tomskside@gmail.com>

conan-center-bot · 2022-03-04T19:17:52Z

All green in build 16 (a048ad62a06dd9c8bdfecb1e886b8068ca9ee9fd):

nspr/4.24@:
All packages built successfully! (All logs)
nspr/4.32@:
All packages built successfully! (All logs)
nspr/4.27@:
All packages built successfully! (All logs)
nspr/4.29@:
All packages built successfully! (All logs)

SpaceIm · 2022-03-07T09:08:10Z

recipes/nspr/all/conanfile.py

+            "--with-mozilla={}".format(yes_no(self.options.with_mozilla)),
+            "--enable-64bit={}".format(yes_no(self.settings.arch in ("armv8", "x86_64", "mips64", "ppc64", "ppc64le"))),
+            "--enable-strip={}".format(yes_no(self.settings.build_type not in ("Debug", "RelWithDebInfo"))),
+            "--enable-debug={}".format(yes_no(self.settings.build_type == "Debug")),
+            "--datarootdir={}".format(tools.unix_path(os.path.join(self.package_folder, "res"))),
            "--disable-cplus",
            "--enable-64bit" if self.settings.arch in ("armv8", "x86_64") else "--disable-64bit",
            "--disable-strip" if self.settings.build_type == "RelWithDebInfo" else "--enable-strip",
            "--enable-debug" if self.settings.build_type == "Debug" else "--disable-debug",
        ]


there are dupicated opions here.

might be a merge artifact

SpaceIm · 2022-03-07T09:09:13Z

recipes/nspr/all/conanfile.py

+                "--enable-static-rtl={}".format(yes_no("MT" in self.settings.compiler.runtime)),
+                "--enable-debug-rtl={}".format(yes_no("d" in self.settings.compiler.runtime)),


Suggested change

"--enable-static-rtl={}".format(yes_no("MT" in self.settings.compiler.runtime)),

"--enable-debug-rtl={}".format(yes_no("d" in self.settings.compiler.runtime)),

"--enable-static-rtl={}".format(yes_no("MT" in msvc_runtime_flag(self))),

"--enable-debug-rtl={}".format(yes_no("d" in msvc_runtime_flag(self))),

SpaceIm · 2022-03-07T09:09:49Z

recipes/nspr/all/conanfile.py

@@ -1,35 +1,39 @@
 from conans import ConanFile, tools, AutoToolsBuildEnvironment


Suggested change

from conans import ConanFile, tools, AutoToolsBuildEnvironment

from conan.tools.microsoft import msvc_runtime_flag

from conans import ConanFile, tools, AutoToolsBuildEnvironment

uilianries

LGTM

prince-chrismc mentioned this pull request Sep 8, 2021

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

prince-chrismc reviewed Sep 16, 2021

View reviewed changes

prince-chrismc previously approved these changes Sep 16, 2021

View reviewed changes

SSE4 closed this Sep 25, 2021

SSE4 reopened this Sep 25, 2021

SSE4 closed this Sep 26, 2021

SSE4 reopened this Sep 26, 2021

madebr closed this Oct 7, 2021

madebr reopened this Oct 7, 2021

jgsogo added the infrastructure Waiting on tools or services belonging to the infra label Oct 11, 2021

This was referenced Oct 28, 2021

[service] Potentially conflicting recipes #3571

Closed

nspr 4.32 #7865

Merged

SSE4 dismissed prince-chrismc’s stale review via be1f33a February 21, 2022 07:57

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Feb 21, 2022

SSE4 force-pushed the nspr_tools_os_info branch from be1f33a to 6a8c9b5 Compare February 21, 2022 08:13

This comment has been minimized.

Sign in to view

madebr added 4 commits February 21, 2022 16:12

nspr: bump + modernize + no tools.os_info in build_requirements

b04e1c8

nspr: add more 64-bit cpus

57db0cd

nspr: DEBUG print config.log

3265175

Revert "nspr: DEBUG print config.log"

d25fdb1

This reverts commit 3a9dd3e.

SSE4 force-pushed the nspr_tools_os_info branch from 6a8c9b5 to d25fdb1 Compare February 21, 2022 09:12

This comment has been minimized.

Sign in to view

SSE4 reviewed Feb 23, 2022

View reviewed changes

recipes/nspr/all/conanfile.py Show resolved Hide resolved

Update recipes/nspr/all/conanfile.py

0a8b084

uilianries previously approved these changes Feb 24, 2022

View reviewed changes

uilianries self-requested a review February 24, 2022 09:19

This comment has been minimized.

Sign in to view

SSE4 added 4 commits March 4, 2022 22:55

- PR_Initialize implicitly calls PR_Cleanup on exiting the primordial…

fa4eeef

… function (https://www-archive.mozilla.org/projects/nspr/reference/html/prinit.html#15758) Signed-off-by: SSE4 <tomskside@gmail.com>

- typo

7d8fc29

Signed-off-by: SSE4 <tomskside@gmail.com>

- support msvc compiler

1ec6211

Signed-off-by: SSE4 <tomskside@gmail.com>

Revert "Update recipes/nspr/all/conanfile.py"

1da5e4d

This reverts commit 0a8b084.

SSE4 dismissed uilianries’s stale review via 1da5e4d March 4, 2022 15:56

- linter

a048ad6

Signed-off-by: SSE4 <tomskside@gmail.com>

This comment has been minimized.

Sign in to view

conan-center-bot added the Unexpected Error label Mar 4, 2022

SSE4 closed this Mar 4, 2022

SSE4 reopened this Mar 4, 2022

This comment has been minimized.

Sign in to view

conan-center-bot added Unexpected Error and removed Unexpected Error labels Mar 4, 2022

SSE4 closed this Mar 4, 2022

SSE4 reopened this Mar 4, 2022

conan-center-bot removed Unexpected Error Failed labels Mar 4, 2022

SSE4 approved these changes Mar 4, 2022

View reviewed changes

jgsogo approved these changes Mar 7, 2022

View reviewed changes

SpaceIm suggested changes Mar 7, 2022

View reviewed changes

uilianries approved these changes Mar 7, 2022

View reviewed changes

conan-center-bot merged commit 3fcd880 into conan-io:master Mar 7, 2022

SpaceIm mentioned this pull request Mar 7, 2022

nspr: relocatable shared libs on macOS + various fixes #9643

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nspr: bump + modernize + no tools.os_info in `build_requirements` #7212

nspr: bump + modernize + no tools.os_info in `build_requirements` #7212

madebr commented Sep 8, 2021

madebr commented Sep 8, 2021 •

edited

Loading

timblechmann commented Sep 9, 2021

prince-chrismc Sep 16, 2021

uilianries Sep 22, 2021 •

edited

Loading

SSE4 Mar 4, 2022

prince-chrismc commented Oct 7, 2021

jgsogo commented Oct 11, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented Mar 4, 2022

SpaceIm Mar 7, 2022

SSE4 Mar 7, 2022

SpaceIm Mar 7, 2022

SpaceIm Mar 7, 2022

uilianries left a comment

		"--enable-static-rtl={}".format(yes_no("MT" in self.settings.compiler.runtime)),
		"--enable-debug-rtl={}".format(yes_no("d" in self.settings.compiler.runtime)),

		@@ -1,35 +1,39 @@
		from conans import ConanFile, tools, AutoToolsBuildEnvironment

	from conans import ConanFile, tools, AutoToolsBuildEnvironment
	from conan.tools.microsoft import msvc_runtime_flag
	from conans import ConanFile, tools, AutoToolsBuildEnvironment

nspr: bump + modernize + no tools.os_info in build_requirements #7212

nspr: bump + modernize + no tools.os_info in build_requirements #7212

Conversation

madebr commented Sep 8, 2021

madebr commented Sep 8, 2021 • edited Loading

timblechmann commented Sep 9, 2021

prince-chrismc Sep 16, 2021

Choose a reason for hiding this comment

uilianries Sep 22, 2021 • edited Loading

Choose a reason for hiding this comment

SSE4 Mar 4, 2022

Choose a reason for hiding this comment

prince-chrismc commented Oct 7, 2021

jgsogo commented Oct 11, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented Mar 4, 2022

SpaceIm Mar 7, 2022

Choose a reason for hiding this comment

SSE4 Mar 7, 2022

Choose a reason for hiding this comment

SpaceIm Mar 7, 2022

Choose a reason for hiding this comment

SpaceIm Mar 7, 2022

Choose a reason for hiding this comment

uilianries left a comment

Choose a reason for hiding this comment

nspr: bump + modernize + no tools.os_info in `build_requirements` #7212

nspr: bump + modernize + no tools.os_info in `build_requirements` #7212

madebr commented Sep 8, 2021 •

edited

Loading

uilianries Sep 22, 2021 •

edited

Loading