-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restinio: bump deps + modernize #7101
Conversation
All green in build 1 (
|
Upgrading to fmt/8.0.1 breaks this package, no longer compiles with GCC as the format strings has to be constexpr or wrapped in fmt::runtime. |
@kjetilj Please, open an issue reporting your error with details, including your profile and package version, steps to reproduce and log. This PR was tested using different GCC versions, from 5 to 10, and passed by all them. |
Sorry, I am not familiar enough with these packages or conan to create a repro, but I can provide some more details. It will fail with c++20 and gcc (and possibly clang), due to format now requiring the format to be parsed at compile time (https://github.com/fmtlib/fmt/releases/tag/8.0.0). If we look at restinio it will fail to compiler here: I also observed some additional compilation errors, but that one was the most obvious where the API of 8.0.1 is not compatible. |
😕 You can see my pet project running this recipe revision prince-chrismc/user-management@bf5012d#diff-10e08a419e850eba1ebba18fdd28eb7ec1b7e8baa9bcc3b973e2b8891ec726be I have never tried to build with C++20 enabled |
@kjetilj please, open an issue. PRs were made for patch, not discussion. This thread will be lost if followed in a PR. Besides that, this PR is closed, which means, it don't have visibility if someone is looking for the same error. |
ok, I did my best here: |
thank you! |
Specify library name and version: lib/1.0
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!
Just an everyday consumer
conan-center hook activated.