coin-utils: allow cross-build + fix random install issues #7077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 27, 2021
uilianries
previously approved these changes
Aug 27, 2021
This comment has been minimized.
This comment has been minimized.
eb85997 to
773c9ec
Compare
This comment has been minimized.
This comment has been minimized.
|
hum, shared lib is empty while cross-building. static lib is fine. |
|
I guess that issue comes from libtool, but we can't call autoreconf, coin-utils m4 macros are missing in tarball (we need https://github.com/coin-or-tools/BuildTools). |
|
All green in build 5 (
|
prince-chrismc
approved these changes
Aug 28, 2021
| @@ -128,7 +128,7 @@ def package(self): | |||
| self.copy("LICENSE", src=self._source_subfolder, dst="licenses") | |||
| with self._build_context(): | |||
| autotools = self._configure_autotools() | |||
| autotools.install() | |||
| autotools.install(args=["-j1"]) | |||
There was a problem hiding this comment.
Is this required? maybe add a comment if it is?
There was a problem hiding this comment.
could be put under the if macos condition, but install is usually fast
SSE4
approved these changes
Aug 29, 2021
prince-chrismc
approved these changes
Aug 29, 2021
uilianries
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: lib/1.0
Cross-build just works (I've tested Macos M1 and iOS with apple-clang 12).
And fixes #5820
conan-center hook activated.