-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdl2_image 2.0.5 #7075
sdl2_image 2.0.5 #7075
Conversation
This comment has been minimized.
This comment has been minimized.
It has been decided to give a generic name to sdl recipes: sdl, sdl_ttf, sdl_mixer, sdl_image etc. See discussions in this PR #5944 |
This comment has been minimized.
This comment has been minimized.
e2ef899
to
b9b9949
Compare
This comment has been minimized.
This comment has been minimized.
Let's rename the folder to |
self._cmake.definitions["SDL_IS_SHARED"] = self.options["sdl"].shared | ||
|
||
self._cmake.configure(build_dir="build") | ||
return self._cmake | ||
|
||
def build(self): | ||
tools.rmdir(os.path.join(self._source_subfolder, "external")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sdl_image uses a vendored header-only minz.h
.
I tried replacing it with our miniz/2.2.0
.
But it looks like the API changed between 1.x and 2.x.
I just tried their current master with the cmake script of this pr, and it just works. |
This comment has been minimized.
This comment has been minimized.
I was wrong. |
This comment has been minimized.
This comment has been minimized.
Hey guys, It would be nice if (some of ) you gave some constructive feedback on what/how to improve. |
This comment has been minimized.
This comment has been minimized.
does anything block it from making ready for the review? |
Co-authored-by: Uilian Ries <uilianries@gmail.com>
All green in build 9 (
|
This comment seems worthy |
When this new sdl_image release happens, I would add our cmake script as a patch to make it behave the same as the upstream cmake project (to 2.0.5 only). |
this is a port of https://github.com/bincrafters/community/tree/main/recipes/sdl2_image
Specify library name and version: sdl2_image/2.0.5
conan-center hook activated.