Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdl2_image 2.0.5 #7075

Merged
merged 8 commits into from
Oct 1, 2021
Merged

sdl2_image 2.0.5 #7075

merged 8 commits into from
Oct 1, 2021

Conversation

ericLemanissier
Copy link
Contributor

this is a port of https://github.com/bincrafters/community/tree/main/recipes/sdl2_image

Specify library name and version: sdl2_image/2.0.5


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor

SpaceIm commented Aug 27, 2021

It has been decided to give a generic name to sdl recipes: sdl, sdl_ttf, sdl_mixer, sdl_image etc. See discussions in this PR #5944

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@Croydon
Copy link
Contributor

Croydon commented Aug 28, 2021

Let's rename the folder to 2.0.5 as the next version has official CMake support

self._cmake.definitions["SDL_IS_SHARED"] = self.options["sdl"].shared

self._cmake.configure(build_dir="build")
return self._cmake

def build(self):
tools.rmdir(os.path.join(self._source_subfolder, "external"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sdl_image uses a vendored header-only minz.h.
I tried replacing it with our miniz/2.2.0.
But it looks like the API changed between 1.x and 2.x.

@madebr
Copy link
Contributor

madebr commented Aug 28, 2021

Let's rename the folder to 2.0.5 as the next version has official CMake support

I just tried their current master with the cmake script of this pr, and it just works.
I propose to add a patch to 2.0.5 that creates a compatible cmake script.

@conan-center-bot

This comment has been minimized.

@madebr
Copy link
Contributor

madebr commented Aug 28, 2021

sdl_image:shared must be the same as sdl::shared.
Or, we patch sdl_image.

I was wrong.

@conan-center-bot

This comment has been minimized.

@madebr
Copy link
Contributor

madebr commented Aug 29, 2021

Hey guys,
while working on this pr I opened a pr at the upstream SDL_image repo: libsdl-org/SDL_image#189

It would be nice if (some of ) you gave some constructive feedback on what/how to improve.

@conan-center-bot

This comment has been minimized.

@SSE4
Copy link
Contributor

SSE4 commented Sep 26, 2021

does anything block it from making ready for the review?

uilianries
uilianries previously approved these changes Sep 27, 2021
recipes/sdl_image/all/conanfile.py Outdated Show resolved Hide resolved
SSE4
SSE4 previously approved these changes Sep 27, 2021
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@madebr madebr dismissed stale reviews from SSE4 and uilianries via 4cb1f77 September 27, 2021 14:17
@conan-center-bot
Copy link
Collaborator

All green in build 9 (4cb1f77dcadf3b131356d60c688df2f9d4919b49):

  • sdl_image/2.0.5@:
    All packages built successfully! (All logs)

@prince-chrismc
Copy link
Contributor

Let's rename the folder to 2.0.5 as the next version has official CMake support

This comment seems worthy

@madebr
Copy link
Contributor

madebr commented Sep 28, 2021

Let's rename the folder to 2.0.5 as the next version has official CMake support

This comment seems worthy

When this new sdl_image release happens, I would add our cmake script as a patch to make it behave the same as the upstream cmake project (to 2.0.5 only).
See libsdl-org/SDL_image#189
It's very similar to ours.

@conan-center-bot conan-center-bot merged commit 707bd53 into conan-io:master Oct 1, 2021
@ericLemanissier ericLemanissier deleted the sdl2_image branch October 1, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants