pexports: add pexports/0.47 recipe #7050
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
All green in build 3 (
|
| - extern __declspec(dllimport) void __stdcall *GetModuleHandleA(char *name); | ||
| - extern __declspec(dllimport) void __stdcall *GetProcAddress(void *module, char *name); | ||
| + extern __declspec(dllimport) void * __stdcall GetModuleHandleA(char *name); | ||
| + extern __declspec(dllimport) void * __stdcall GetProcAddress(void *module, char *name); |
There was a problem hiding this comment.
for sure, these functions return pointers (HMODULE/HINSTANCE and a function pointer)
seems like upstream has a bug
There was a problem hiding this comment.
I think the C standard says to assume that EAX (=result variable) is clobbered.
| message(FATAL_ERROR "pexports only supports Windows") | ||
| endif() | ||
|
|
||
| include(${CMAKE_BINARY_DIR}/conanbuildinfo.cmake) |
There was a problem hiding this comment.
why so complex CMakeLists.txt for test_package?
did you borrow it somewhere?
There was a problem hiding this comment.
No, it's homebrew.
It's just creating a dll -> running pexports on the dll -> running dlltool/lib to create an import library -> create an exe using the import library.
It's do-able outside cmake by just sequentially executing the commands, but I can re-use some cmake variables here.
| @@ -0,0 +1,32 @@ | |||
| --- pexports.c | |||
| +++ pexports.c | |||
There was a problem hiding this comment.
it seems be a feature patch, but doesn't break when missing
There was a problem hiding this comment.
Indeed. I added it to be able to test pexports on non-Windows systems.
Specify library name and version: pexports/0.47
conan-center hook activated.