-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rapidcheck 20210702 #7037
Add rapidcheck 20210702 #7037
Conversation
This comment has been minimized.
This comment has been minimized.
Mark previous versions as deprecated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A PR after this one removing the old versions would be very welcome 😃
This comment has been minimized.
This comment has been minimized.
around here:
need something like:
|
Will something like that work too? Edit: no :-) |
This comment has been minimized.
This comment has been minimized.
And what is wrong now? 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry. It was my fault for suggesting you to raise an error unconditionally.
From ConanCenter perspective it makes no sense to have a recipe without packages, so we have added that check to prevent it from happening. With my suggestion, all the configurations for those recipes are skipped, so no package is generated.... and CI complains.
Please, just print the error, and we will expect the users eventually read it.
Thanks!
recipes/rapidcheck/all/conanfile.py
Outdated
@@ -51,6 +51,9 @@ def validate(self): | |||
if self.settings.compiler == "Visual Studio" and self.options.shared: | |||
raise ConanInvalidConfiguration("shared is not supported using Visual Studio") | |||
|
|||
if 'cci' not in self.version: | |||
raise ConanInvalidConfiguration("This version has been deprecated in favor of '{}/cci.{}'".format(self.name, self.version)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
raise ConanInvalidConfiguration("This version has been deprecated in favor of '{}/cci.{}'".format(self.name, self.version)) | |
self.output.error("This version has been deprecated in favor of '{}/cci.{}'".format(self.name, self.version)) |
This comment has been minimized.
This comment has been minimized.
All green in build 5 (
|
Specify library name and version: rapidcheck /20210702
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!
Closes #7026
conan-center hook activated.