Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rapidcheck 20210702 #7037

Merged
merged 5 commits into from
Aug 30, 2021

Conversation

dmn-star
Copy link
Contributor

@dmn-star dmn-star commented Aug 24, 2021

Specify library name and version: rapidcheck /20210702

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!

Closes #7026

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

Mark previous versions as deprecated
@conan-center-bot conan-center-bot removed the Bump version PR bumping version without recipe modifications label Aug 25, 2021
jgsogo
jgsogo previously approved these changes Aug 25, 2021
Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A PR after this one removing the old versions would be very welcome 😃

@conan-center-bot

This comment has been minimized.

@SSE4
Copy link
Contributor

SSE4 commented Aug 25, 2021

around here:

if tools.Version(self.version) < "20201218":

need something like:

version = self.version
if version.startswith("cci."):
    version = version[4:]

@dmn-star
Copy link
Contributor Author

dmn-star commented Aug 25, 2021

Will something like that work too?
if (self.version) < "cci.20201218"

Edit: no :-)

@dmn-star
Copy link
Contributor Author

conan-io/conan#9473

@conan-center-bot

This comment has been minimized.

@dmn-star
Copy link
Contributor Author

And what is wrong now? 🤔

Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. It was my fault for suggesting you to raise an error unconditionally.

From ConanCenter perspective it makes no sense to have a recipe without packages, so we have added that check to prevent it from happening. With my suggestion, all the configurations for those recipes are skipped, so no package is generated.... and CI complains.

Please, just print the error, and we will expect the users eventually read it.

Thanks!

@@ -51,6 +51,9 @@ def validate(self):
if self.settings.compiler == "Visual Studio" and self.options.shared:
raise ConanInvalidConfiguration("shared is not supported using Visual Studio")

if 'cci' not in self.version:
raise ConanInvalidConfiguration("This version has been deprecated in favor of '{}/cci.{}'".format(self.name, self.version))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
raise ConanInvalidConfiguration("This version has been deprecated in favor of '{}/cci.{}'".format(self.name, self.version))
self.output.error("This version has been deprecated in favor of '{}/cci.{}'".format(self.name, self.version))

@jgsogo jgsogo mentioned this pull request Aug 27, 2021
4 tasks
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

All green in build 5 (61632e879a0febe1356094cd18abdb7e2983e090):

  • rapidcheck/20210107@:
    All packages built successfully! (All logs)

  • rapidcheck/cci.20210107@:
    All packages built successfully! (All logs)

  • rapidcheck/20200131@:
    All packages built successfully! (All logs)

  • rapidcheck/cci.20200131@:
    All packages built successfully! (All logs)

  • rapidcheck/cci.20210702@:
    All packages built successfully! (All logs)

@SSE4 SSE4 requested a review from uilianries August 29, 2021 14:40
@conan-center-bot conan-center-bot merged commit b5d4259 into conan-io:master Aug 30, 2021
@dmn-star dmn-star deleted the br_rapidcheck_20210702 branch August 30, 2021 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] rapidcheck/20210702
6 participants