Add soil2 #6860

FernandoVelcic · 2021-08-15T00:33:22Z

Specify library name and version: soil2/1.20

I want to add soil2 library because it's so useful for game development

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

conan-center-bot · 2021-08-15T03:09:54Z

Failure in build 5 (0ec8c0ae705f844466606180a7229a56e9ccfa89):

soil2/1.20@:
CI failed to create some packages (All logs)

Logs for packageID c0059683f10e1f9ccd34130934eeacf593c58e6a:

[settings]
arch=x86_64
arch_build=x86_64
build_type=Release
compiler=apple-clang
compiler.libcxx=libc++
compiler.version=11.0
os=Macos
os_build=Macos

[...]
[settings]
arch=x86_64
arch_build=x86_64
build_type=Release
compiler=apple-clang
compiler.libcxx=libc++
compiler.version=11.0
os=Macos
os_build=Macos
[options]
[build_requires]
[env]

soil2/1.20: Forced build from source
Installing package: soil2/1.20
Requirements
    opengl/system from 'conan-center' - Cache
    soil2/1.20 from local cache - Cache
Packages
    opengl/system:5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9 - Cache
    soil2/1.20:c0059683f10e1f9ccd34130934eeacf593c58e6a - Build
Build requirements
    premake/5.0.0-alpha14 from 'conan-center' - Cache
Build requirements packages
    premake/5.0.0-alpha14:103f6067a947f366ef91fc1b7da351c588d1827f - Cache

Installing (downloading, building) binaries...
opengl/system: Already installed!
[HOOK - conan-center.py] post_package_info(): [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] OK
[HOOK - conan-center.py] post_package_info(): [LIBRARY DOES NOT EXIST (KB-H054)] OK
premake/5.0.0-alpha14: Already installed!
premake/5.0.0-alpha14: Appending PATH environment variable: /Users/jenkins/w/BuildSingleReference/.conan/data/premake/5.0.0-alpha14/_/_/package/103f6067a947f366ef91fc1b7da351c588d1827f/bin
[HOOK - conan-center.py] post_package_info(): [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] OK
[HOOK - conan-center.py] post_package_info(): [LIBRARY DOES NOT EXIST (KB-H054)] OK
soil2/1.20: Applying build-requirement: premake/5.0.0-alpha14

----Running------
> brew install xquartz
-----------------
Error: /usr/local/Cellar is not writable. You should change the
ownership and permissions of /usr/local/Cellar back to your
user account:
  sudo chown -R $(whoami) /usr/local/Cellar
Error: No available formula with the name "xquartz" 
Found a cask named "xquartz" instead. Try
  brew cask install xquartz

premake/5.0.0-alpha14: WARN: Lib folder doesn't exist, can't collect libraries: /Users/jenkins/w/BuildSingleReference/.conan/data/premake/5.0.0-alpha14/_/_/package/103f6067a947f366ef91fc1b7da351c588d1827f/lib
soil2/1.20: ERROR: while executing system_requirements(): Error 1 while executing brew install xquartz
ERROR: Error in system requirements

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

madebr · 2021-08-15T17:08:21Z

recipes/soil2/all/conanfile.py

+        # Visual Studio users: SOIL2 will need to be compiled as C++ source ( at least the file etc1_utils.c ), since VC compiler doesn't support C99
+        del self.settings.compiler.libcxx


The libcxx is there for the c++ runtime library.
gcc has libstdc++ and libstdc++11.
clang has libstdc++, libstdc++11 and clang++.
MSVC has no specific c++ runtime, only its general runtime (MT/MD/MTd/MDd)

madebr · 2021-08-15T17:08:39Z

recipes/soil2/all/conanfile.py

+        if not tools.which("premake"):
+            self.build_requires("premake/5.0.0-alpha14")


Don't depend on a locally installed version. It might be bugged and out-of-date.

Suggested change

if not tools.which("premake"):

self.build_requires("premake/5.0.0-alpha14")

self.build_requires("premake/5.0.0-alpha14")

madebr · 2021-08-15T17:10:11Z

recipes/soil2/all/conanfile.py

+        tools.get(**self.conan_data["sources"][self.version])
+        extracted_dir = "SOIL2-release-" + self.version
+        os.rename(extracted_dir, self._source_subfolder)


conan learned to do this in one method.

Suggested change

tools.get(**self.conan_data["sources"][self.version])

extracted_dir = "SOIL2-release-" + self.version

os.rename(extracted_dir, self._source_subfolder)

tools.get(**self.conan_data["sources"][self.version],

destinations=self._source_subfolder, strip_root=True)

madebr · 2021-08-15T17:14:26Z

recipes/soil2/all/conanfile.py

+
+    def system_requirements(self):
+        if self.settings.os == "Macos":
+            self.run("brew install xquartz")


This is a big no-no.
As a package manager ourselves, we don't want to depend as little as possible on other package manager.
So please create a xquartz recipe which can be added as a requirement here.

and why does it need xquartz?

I tested bincrafters recipe without xquartz and CI passed on macos, so this method can probably be simply removed

@Croydon do you remember why it was added in bincrafters/conan-soil2@0cbc7c6#diff-63f09721ade419d29886e8190ffa3c9c756baa9bef8802a7f2aeabf3b545164fR36 ?

I guess for opengl, but it doesn't make sense.

madebr · 2021-08-15T17:15:52Z

recipes/soil2/all/conanfile.py

+                        build_type = "debug"
+
+                    msbuild = MSBuild(self)
+                    msbuild.build("SOIL2.sln", targets=["soil2-static-lib"], platforms={"x86": "Win32"}, build_type=build_type)


The premake script also provides a soil2-shared-lib target

madebr · 2021-08-15T17:17:25Z

recipes/soil2/all/conanfile.py

+
+    def build(self):
+        config = "debug" if self.settings.build_type == "Debug" else "release"
+        architecture = "x86" if self.settings.arch == "x86" else "x86_64"


There is also armv8 for Apple, raspberry pi, ...
If only intel architectures are supported, please add a check in a validate method.

madebr · 2021-08-15T17:18:25Z

recipes/soil2/all/test_package/conanfile.py

+        bin_path = os.path.join("bin", "test_package")
+        img_path = os.path.join(self.source_folder, "img_test.png")
+        self.run("%s %s" % (bin_path, img_path), run_environment=True)


Suggested change

bin_path = os.path.join("bin", "test_package")

img_path = os.path.join(self.source_folder, "img_test.png")

self.run("%s %s" % (bin_path, img_path), run_environment=True)

if not tools.cross_building(self):

bin_path = os.path.join("bin", "test_package")

img_path = os.path.join(self.source_folder, "img_test.png")

self.run("%s %s" % (bin_path, img_path), run_environment=True)

madebr · 2021-08-15T17:18:51Z

recipes/soil2/all/test_package/test_package.cpp

+    glfwWindowHint(GLFW_OPENGL_FORWARD_COMPAT, GL_TRUE);
+    glfwWindowHint(GLFW_RESIZABLE, GL_FALSE);
+
+    GLFWwindow* window = glfwCreateWindow(800, 600, "OpenGL", NULL, NULL);


I don't this this will work on headless build machines.

madebr · 2021-08-15T17:19:36Z

recipes/soil2/all/conanfile.py

+import os
+
+
+class soil2Conan(ConanFile):


For my tools.get suggestion.

Suggested change

import os

class soil2Conan(ConanFile):

import os

required_conan_version = ">=1.33.0"

class Soil2Conan(ConanFile):

ericLemanissier · 2021-08-15T17:46:00Z

This recipe looks like bincrafters recipe. If it is based on it, then please mention that it is a port of https://github.com/bincrafters/conan-soil2 in the PR description.

stale · 2021-09-18T22:52:56Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale · 2021-10-19T02:28:42Z

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

FernandoVelcic and others added 5 commits May 5, 2021 16:33

Add hexdump/1.0.0

2b955c7

Merge remote-tracking branch 'github/master'

d9a4608

Merge commit 'd9a46087fbac16f1afeec81fc2adc5d3c6b54290'

07e87f6

miniaudio: Bump to 0.10.40

92c2253

Merge remote-tracking branch 'github/master'

4ec15fe

github-actions bot mentioned this pull request Aug 15, 2021

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Aug 15, 2021

FernandoVelcic force-pushed the master branch from 9b5d454 to b701694 Compare August 15, 2021 00:46

This comment has been minimized.

Sign in to view

FernandoVelcic force-pushed the master branch from b701694 to 1c85bda Compare August 15, 2021 01:00

This comment has been minimized.

Sign in to view

FernandoVelcic force-pushed the master branch from 1c85bda to f367fbb Compare August 15, 2021 01:29

This comment has been minimized.

Sign in to view

Add soil2/1.20

0ec8c0a

FernandoVelcic force-pushed the master branch from f367fbb to 0ec8c0a Compare August 15, 2021 02:59

madebr reviewed Aug 15, 2021

View reviewed changes

stale bot added the stale label Sep 18, 2021

stale bot closed this Oct 19, 2021

valgur mentioned this pull request Jan 26, 2024

Stale recipe PRs possibly worth another look #22553

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add soil2 #6860

Add soil2 #6860

FernandoVelcic commented Aug 15, 2021 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented Aug 15, 2021

madebr Aug 15, 2021

madebr Aug 15, 2021

madebr Aug 15, 2021

madebr Aug 15, 2021

SpaceIm Aug 16, 2021

ericLemanissier Aug 17, 2021

ericLemanissier Aug 18, 2021

SpaceIm Aug 18, 2021

madebr Aug 15, 2021

madebr Aug 15, 2021

madebr Aug 15, 2021

madebr Aug 15, 2021

madebr Aug 15, 2021

ericLemanissier commented Aug 15, 2021

stale bot commented Sep 18, 2021

stale bot commented Oct 19, 2021

		# Visual Studio users: SOIL2 will need to be compiled as C++ source ( at least the file etc1_utils.c ), since VC compiler doesn't support C99
		del self.settings.compiler.libcxx

		if not tools.which("premake"):
		self.build_requires("premake/5.0.0-alpha14")

Add soil2 #6860

Add soil2 #6860

Conversation

FernandoVelcic commented Aug 15, 2021 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented Aug 15, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ericLemanissier commented Aug 15, 2021

stale bot commented Sep 18, 2021

stale bot commented Oct 19, 2021

FernandoVelcic commented Aug 15, 2021 •

edited

Loading