Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hdf4: improve dependencies handling + allow macos M1 shared + modernize #6676

Merged
merged 6 commits into from
Sep 28, 2021

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Aug 4, 2021

Specify library name and version: lib/1.0

cross-build can still fail in some circumstances, due to 2 try_run (same issue in hdf5)


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Aug 4, 2021

CMake Error at build/93707e7b45c2f155e04a4c4da15529436f77faa5/FindJPEG.cmake:39 (add_library):
Attempting to use @rpath without CMAKE_SHARED_LIBRARY_RUNTIME_C_FLAG being
set. This could be because you are using a Mac OS X version less than 10.5
or because CMake's platform configuration is corrupt.

I can't reproduce this issue on my Mac

@stale
Copy link

stale bot commented Sep 3, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 3, 2021
@stale stale bot removed the stale label Sep 4, 2021
@conan-center-bot
Copy link
Collaborator

All green in build 2 (1b1992bb9a0475bd84358e8f7389bf57d0b559f7):

  • hdf4/4.2.15@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 48ad904 into conan-io:master Sep 28, 2021
@SpaceIm SpaceIm deleted the fix/hdf4-robust-deps branch October 3, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants