- [waf] skip test for cross-building (m1) #6122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SSE4 <tomskside@gmail.com>
This comment has been minimized.
This comment has been minimized.
madebr
reviewed
Jul 1, 2021
| @@ -9,11 +9,16 @@ class TestPackageConan(ConanFile): | |||
| exports_sources = "a.cpp", "b.cpp", "main.c", "main.cpp", "wscript" | |||
|
|
|||
There was a problem hiding this comment.
Perhaps this should contain test_type = "build_requires" + required_conan_version = ">=1.36.0"?
https://docs.conan.io/en/latest/devtools/build_requires.html#testing-build-requires
There was a problem hiding this comment.
it may contain that, still, waf.exe will be ARMv8 and it will fail?
There was a problem hiding this comment.
waf is python-only. There is no binary that I'm aware of.
This recipe still uses os_build and arch_build.
Perhaps switching to os/arch will improve cross builds?
There was a problem hiding this comment.
it should, I am not a fan of os_build/arch_build
jgsogo
suggested changes
Jul 3, 2021
|
All green in build 2 (
|
jgsogo
approved these changes
Jul 5, 2021
madebr
approved these changes
Jul 5, 2021
prince-chrismc
approved these changes
Jul 5, 2021
AndreyMlashkin
pushed a commit
to AndreyMlashkin/conan-center-index
that referenced
this pull request
Jul 19, 2021
* - [waf] skip test for cross-building (m1) Signed-off-by: SSE4 <tomskside@gmail.com> * Update conanfile.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: waf/all
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!
conan-center hook activated.