-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gsl/2.7 #6098
Add gsl/2.7 #6098
Conversation
fdefb32
to
234855f
Compare
Implements #6097 |
This comment has been minimized.
This comment has been minimized.
Split out the changes in the |
13289eb
to
47d5ec2
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@Croydon , I am confused as to what the error is telling me. Was wondering if you could provide guidance? |
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@NolanC33 Consider rl-enjoyer#1 |
Awesome, thanks. Out of curiosity, what's the rationale behind that requirement? |
This was the trigger: #6348 (comment) |
will remove |
This comment has been minimized.
This comment has been minimized.
Not too sure about the other error:
|
Those are warnings. To eliminate these types of warnings, I have added |
Ah ok. They do seem to sink the build though. At least I can't find anything else in the log that could be it. Also interesting how the warnings arise on only one configuration for both 2.6 & 2.7. |
Those are warnings, the error was due to the typo bug in the |
Ok cool. If you look at https://c3i.jfrog.io/c3i/misc/logs/pr/6098/17-configs/windows-visual_studio/gsl/2.7//995e0f0b86a651012a3bfca00d60f35ae037db5e-build.txt you see the complaint about the libs. And not the complaint about the rename typo. (from https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/6098/17-configs/windows-visual_studio/gsl/2.7//summary.json) Now if you look at https://c3i.jfrog.io/c3i/misc/logs/pr/6098/17-configs/windows-visual_studio/gsl/2.7//f42ebec2d0ee7d5c41713cd8eee15cf988b0d202-build.txt it complains about the rename typo and not the libs. (also from https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/6098/17-configs/windows-visual_studio/gsl/2.7//summary.json) I suppose we'll see once the current jobs are done, but if f42ebec2d0ee7d5c41713cd8eee15cf988b0d202 failed because of the typo, would we expect to see that in the 995e0f0b86a651012a3bfca00d60f35ae037db5elog as well? |
The warning about the libdirs is shown after executing the The rename typo bug happens in |
Ahh ok, thanks |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
b67243d
to
3e11dbf
Compare
Sorry about that. Didn't mean to dismiss your review. Could you repost it? @madebr |
Do I need to rebase this off master? |
That's not needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Specify library name and version: gsl/2.7
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!
close #6097
conan-center hook activated.