-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added recipe for openjdk #5792
added recipe for openjdk #5792
Changes from 6 commits
794c28d
fee4c00
cb45d25
1186719
2f69f4a
74d890d
8c87412
9e093ce
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
sources: | ||
"16.0.1": | ||
Windows: | ||
url: "https://download.java.net/java/GA/jdk16.0.1/7147401fd7354114ac51ef3e1328291f/9/GPL/openjdk-16.0.1_windows-x64_bin.zip" | ||
sha256: "733b45b09463c97133d70c2368f1b9505da58e88f2c8a84358dd4accfd06a7a4" | ||
Linux: | ||
url: "https://download.java.net/java/GA/jdk16.0.1/7147401fd7354114ac51ef3e1328291f/9/GPL/openjdk-16.0.1_linux-x64_bin.tar.gz" | ||
sha256: "b1198ffffb7d26a3fdedc0fa599f60a0d12aa60da1714b56c1defbce95d8b235" | ||
Macos: | ||
url: "https://download.java.net/java/GA/jdk16.0.1/7147401fd7354114ac51ef3e1328291f/9/GPL/openjdk-16.0.1_osx-x64_bin.tar.gz" | ||
sha256: "6098f839954439d4916444757c542c1b8778a32461706812d41cc8bbefce7f2f" |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
from conans import ConanFile, tools | ||
from conans.errors import ConanInvalidConfiguration | ||
import os | ||
|
||
required_conan_version = ">=1.33.0" | ||
|
||
|
||
class OpenJDK(ConanFile): | ||
name = "openjdk" | ||
url = "https://github.com/conan-io/conan-center-index/" | ||
description = "Java Development Kit builds, from Oracle" | ||
homepage = "https://jdk.java.net" | ||
license = "GPL-2.0-with-classpath-exception" | ||
topics = ("java", "jdk", "openjdk") | ||
settings = "os", "arch" | ||
no_copy_source = True | ||
|
||
@property | ||
def _source_subfolder(self): | ||
return "source_subfolder" | ||
|
||
def configure(self): | ||
if self.settings.arch != "x86_64": | ||
raise ConanInvalidConfiguration("Unsupported Architecture. This package currently only supports x86_64.") | ||
if self.settings.os not in ["Windows", "Macos", "Linux"]: | ||
raise ConanInvalidConfiguration("Unsupported os. This package currently only support Linux/Macos/Windows") | ||
|
||
def build(self): | ||
tools.get(**self.conan_data["sources"][self.version][str(self.settings.os)], | ||
destination=self._source_subfolder, strip_root=True) | ||
|
||
def package(self): | ||
if self.settings.os == "Macos": | ||
_source_subfolder = os.path.join(self._source_subfolder, "jdk-{}.jdk".format(self.version), "Contents", "Home") | ||
else: | ||
_source_subfolder = self._source_subfolder | ||
self.copy(pattern="*", dst="bin", src=os.path.join(_source_subfolder, "bin"), | ||
excludes=("msvcp140.dll", "vcruntime140.dll", "vcruntime140_1.dll")) | ||
self.copy(pattern="*", dst="include", src=os.path.join(_source_subfolder, "include")) | ||
self.copy(pattern="*", dst="lib", src=os.path.join(_source_subfolder, "lib")) | ||
self.copy(pattern="*", dst=os.path.join("lib", "jmods"), src=os.path.join(_source_subfolder, "jmods")) | ||
self.copy(pattern="*", dst="licenses", src=os.path.join(_source_subfolder, "legal")) | ||
# conf folder is required for security settings, to avoid | ||
# java.lang.SecurityException: Can't read cryptographic policy directory: unlimited | ||
# https://github.com/conan-io/conan-center-index/pull/4491#issuecomment-774555069 | ||
self.copy(pattern="*", dst="conf", src=os.path.join(_source_subfolder, "conf")) | ||
|
||
def package_info(self): | ||
self.output.info("Creating JAVA_HOME environment variable with : {0}".format(self.package_folder)) | ||
self.env_info.JAVA_HOME = self.package_folder | ||
|
||
self.output.info("Appending PATH environment variable with : {0}".format(os.path.join(self.package_folder, "bin"))) | ||
self.env_info.PATH.append(os.path.join(self.package_folder, "bin")) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
from conans import ConanFile | ||
boussaffawalid marked this conversation as resolved.
Show resolved
Hide resolved
|
||
from conans.errors import ConanException | ||
from io import StringIO | ||
|
||
required_conan_version = ">=1.36.0" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What happens if you're running an older version? The main recipe works and then it errors out during test? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It raises a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes I know it raises an error, but I'm talking about the placement. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice catch There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. test_package is not evaluated before the build There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. so should I add the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think you are correct here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it does not make sense to require two different versions. lets use 1.36 in main recipe There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can build the main recipe without a test recipe ( There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is ok. For a client using |
||
|
||
|
||
class TestPackage(ConanFile): | ||
test_type = "build_requires" | ||
|
||
def build(self): | ||
pass # nothing to build, but tests should not warn | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Perhaps compiling something JNI? |
||
|
||
def test(self): | ||
output = StringIO() | ||
self.run("java --version", output=output, run_environment=True) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this should be run conditionally, when not cross building. |
||
print(output.getvalue) | ||
version_info = output.getvalue() | ||
if "openjdk" in version_info: | ||
pass | ||
else: | ||
raise ConanException("java call seems not use the openjdk bin") | ||
boussaffawalid marked this conversation as resolved.
Show resolved
Hide resolved
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
versions: | ||
"16.0.1": | ||
folder: all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This checks should go in
validate()
https://docs.conan.io/en/latest/reference/conanfile/methods.html#validate