libsass: fix build requirements versions conflicts #5597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
versions of transitive build requirements can't be overriden, so just rely on libtool to drag autoconf through automake and avoid versions conflicts
4 tasks
|
All green in build 1 (
|
|
@madebr can you take a look? I guess you know the relationship of libtool/autoconf/automake better |
prince-chrismc
approved these changes
May 22, 2021
SSE4
approved these changes
Jun 3, 2021
madebr
approved these changes
Jun 3, 2021
madebr
pushed a commit
to madebr/conan-center-index
that referenced
this pull request
Jun 21, 2021
* no os.rename * fix conflicts in build requirements versions of transitive build requirements can't be overriden, so just rely on libtool to drag autoconf through automake and avoid versions conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: lib/1.0
automake now requires autoconf/2.71, but this recipe "build requires" libtool/2.4.6 (which drags automake) and autoconf/2.69.
Problem: build requirements can't override transitive dependencies, so build fails.
Therefore, I recommend to only require the "top level recipe" in build requirement, here libtool, to minimize maintenance burden.
conan-center hook activated.